Enable jarhell check #3227
Merged
Enable jarhell check #3227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarHell was disabled due to an issue with Kafka where there were multiple copies of the same class packaged inside of a release and test distribution jar. This was resolved with apache/kafka#12407 The Kafka change has been merged, released, and pulled into this repository so we are removing the workaround to supress jar hell issue detection. - Resolves opensearch-project#1938 Signed-off-by: Peter Nied <petern@amazon.com>
peternied
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
Codecov Report
@@ Coverage Diff @@
## main #3227 +/- ##
============================================
- Coverage 62.43% 62.42% -0.02%
Complexity 3351 3351
============================================
Files 254 254
Lines 19748 19748
Branches 3334 3334
============================================
- Hits 12330 12328 -2
+ Misses 5789 5788 -1
- Partials 1629 1632 +3 |
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
reta
approved these changes
Aug 22, 2023
cwperks
approved these changes
Aug 22, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 22, 2023
JarHell was disabled due to an issue with Kafka where there were multiple copies of the same class packaged inside of a release and test distribution jar. This was resolved with apache/kafka#12407 The Kafka change has been merged, released, and pulled into this repository so we are removing the workaround to supress jar hell issue detection. Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit 75f529a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peternied
pushed a commit
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JarHell was disabled due to an issue with Kafka where there were multiple copies of the same class packaged inside of a release and test distribution jar. This was resolved with apache/kafka#12407
The Kafka change has been merged, released, and pulled into this repository so we are removing the workaround to supress jar hell issue detection.
Issues Resolved
Testing
./gradlew jarhellpassesCheck List
New functionality includes testingNew functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.