Skip to content

MINOR: doc: note how JDK-8136913 can affect client SASL#13071

Merged
tombentley merged 2 commits intoapache:trunkfrom
tombentley:MINOR-sasl-dns-doc
Jan 6, 2023
Merged

MINOR: doc: note how JDK-8136913 can affect client SASL#13071
tombentley merged 2 commits intoapache:trunkfrom
tombentley:MINOR-sasl-dns-doc

Conversation

@tombentley
Copy link
Member

No description provided.

@fvaleri
Copy link
Contributor

fvaleri commented Jan 4, 2023

LGTM. This can spare some headaches.

for the selected mechanism.</p>

<p>Note: Due to how the JRE implements reverse DNS lookups, clients may observe
slow SASL handshakes if fully qualified domain names are not used when configuring a broker's
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding When establishing connections to brokers via SASL, clients perform a reverse DNS lookup of the provided broker addresses. just before?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I reworded it slightly. Let me know what you think.

Copy link
Member

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombentley tombentley merged commit 95910af into apache:trunk Jan 6, 2023
@tombentley tombentley deleted the MINOR-sasl-dns-doc branch January 6, 2023 10:31
rajinisivaram added a commit to confluentinc/kafka that referenced this pull request Jan 9, 2023
…9-jan-2023

* apache/trunk: (16 commits)
  KAFKA-14570: Fix parenthesis in verifyFullFetchResponsePartitions output (apache#13072)
  MINOR: Remove public mutable fields from ProducerAppendInfo (apache#13091)
  KAFKA-14558: Move/Rewrite LastRecord, TxnMetadata, BatchMetadata, ProducerStateEntry, and ProducerAppendInfo to the storage module (apache#13043)
  KAFKA-14535: Fix flaky EndToEndAuthorization tests which were sensitive to ACL change reordering (apache#13086)
  KAFKA-9087 Replace log high watermark by future log high watermark wh… (apache#13075)
  MINOR: add error reason when controller failed to handle events (apache#13050)
  MINOR: doc: note how JDK-8136913 can affect client SASL (apache#13071)
  2023 (apache#13083)
  KAFKA-14279; Add 3.3.x to core compatibility tests (apache#13076)
  MINOR Fixed doc generation for LogConfig class in genTopicConfigDocs. (apache#13079)
  ...
guozhangwang pushed a commit to guozhangwang/kafka that referenced this pull request Jan 25, 2023
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Federico Valeri <fedevaleri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants