Skip to content

MINOR Fixed doc generation for LogConfig class in genTopicConfigDocs.#13079

Merged
satishd merged 1 commit intoapache:trunkfrom
satishd:fix-logconfig-docgen
Jan 5, 2023
Merged

MINOR Fixed doc generation for LogConfig class in genTopicConfigDocs.#13079
satishd merged 1 commit intoapache:trunkfrom
satishd:fix-logconfig-docgen

Conversation

@satishd
Copy link
Member

@satishd satishd commented Jan 5, 2023

MINOR Fixed doc generation for LogConfig class in genTopicConfigDocs.

This was a regression caused by #13049

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@satishd
Copy link
Member Author

satishd commented Jan 5, 2023

cc @ijuma @showuon @omkreddy

@satishd satishd requested a review from showuon January 5, 2023 01:42
@satishd satishd force-pushed the fix-logconfig-docgen branch from 0d653e0 to e4bd5aa Compare January 5, 2023 01:43
Copy link
Member

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@ijuma
Copy link
Member

ijuma commented Jan 5, 2023

We should ideally run this as part of the CI build. Maybe file a JIRA for it?

@satishd
Copy link
Member Author

satishd commented Jan 5, 2023

@ijuma: Filed https://issues.apache.org/jira/browse/KAFKA-14574 as you suggested.

@satishd
Copy link
Member Author

satishd commented Jan 5, 2023

These intermittent test failures are not related to this change, merging it to trunk.

@satishd satishd merged commit 4728880 into apache:trunk Jan 5, 2023
rajinisivaram added a commit to confluentinc/kafka that referenced this pull request Jan 9, 2023
…9-jan-2023

* apache/trunk: (16 commits)
  KAFKA-14570: Fix parenthesis in verifyFullFetchResponsePartitions output (apache#13072)
  MINOR: Remove public mutable fields from ProducerAppendInfo (apache#13091)
  KAFKA-14558: Move/Rewrite LastRecord, TxnMetadata, BatchMetadata, ProducerStateEntry, and ProducerAppendInfo to the storage module (apache#13043)
  KAFKA-14535: Fix flaky EndToEndAuthorization tests which were sensitive to ACL change reordering (apache#13086)
  KAFKA-9087 Replace log high watermark by future log high watermark wh… (apache#13075)
  MINOR: add error reason when controller failed to handle events (apache#13050)
  MINOR: doc: note how JDK-8136913 can affect client SASL (apache#13071)
  2023 (apache#13083)
  KAFKA-14279; Add 3.3.x to core compatibility tests (apache#13076)
  MINOR Fixed doc generation for LogConfig class in genTopicConfigDocs. (apache#13079)
  ...
guozhangwang pushed a commit to guozhangwang/kafka that referenced this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants