KAFKA-14568: Move FetchDataInfo and related to storage module#13085
Merged
ijuma merged 9 commits intoapache:trunkfrom Jan 13, 2023
Merged
KAFKA-14568: Move FetchDataInfo and related to storage module#13085ijuma merged 9 commits intoapache:trunkfrom
ijuma merged 9 commits intoapache:trunkfrom
Conversation
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
Contributor
Author
ijuma
reviewed
Jan 6, 2023
storage/src/main/java/org/apache/kafka/server/log/internals/FetchIsolation.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
ijuma
reviewed
Jan 6, 2023
ijuma
reviewed
Jan 6, 2023
storage/src/main/java/org/apache/kafka/server/log/internals/FetchIsolation.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
Contributor
Author
|
Let's wait for CI builds, but it should be good now. Thanks for the review. |
ijuma
reviewed
Jan 8, 2023
Member
ijuma
left a comment
ijuma
left a comment
There was a problem hiding this comment.
I took a pass and left some comments. Note that the fetch path is performance sensitive, so we have to be careful with collection conversions and other such things.
clients/src/main/java/org/apache/kafka/common/utils/FetchRequestUtils.java
Outdated
Show resolved
Hide resolved
storage/src/main/java/org/apache/kafka/server/log/internals/FetchIsolation.java
Outdated
Show resolved
Hide resolved
storage/src/main/java/org/apache/kafka/server/log/internals/FetchParams.java
Outdated
Show resolved
Hide resolved
storage/src/main/java/org/apache/kafka/server/log/internals/FetchParams.java
Outdated
Show resolved
Hide resolved
storage/src/main/java/org/apache/kafka/server/log/internals/FetchParams.java
Show resolved
Hide resolved
storage/src/main/java/org/apache/kafka/server/log/internals/FetchDataInfo.java
Show resolved
Hide resolved
Contributor
Author
Yes and thanks for the detailed reviews. Much appreciated. |
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
* apache-github/trunk: KAFKA-14601: Improve exception handling in KafkaEventQueue apache#13089 KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface (apache#12886) KAFKA-14530: Check state updater more often (apache#13017) KAFKA-14304 Use boolean for ZK migrating brokers in RPC/record (apache#13103) KAFKA-14003 Kafka Streams JUnit4 to JUnit5 migration part 2 (apache#12301) KAFKA-14607: Move Scheduler/KafkaScheduler to server-common (apache#13092) KAFKA-14367; Add `OffsetFetch` to the new `GroupCoordinator` interface (apache#12870) KAFKA-14557; Lock metadata log dir (apache#13058) MINOR: Implement toString method for TopicAssignment and PartitionAssignment (apache#13101) KAFKA-12558: Do not prematurely mutate internal partition state in Mirror Maker 2 (apache#11818) KAFKA-14540: Fix DataOutputStreamWritable#writeByteBuffer (apache#13032) KAFKA-14600: Reduce flakiness in ProducerIdExpirationTest (apache#13087) KAFKA-14279: Add 3.3.x streams system tests (apache#13077) MINOR: bump streams quickstart pom versions and add to list in gradle.properties (apache#13064) MINOR: Update KRaft cluster upgrade documentation for 3.4 (apache#13063) KAFKA-14493: Introduce Zk to KRaft migration state machine STUBs in KRaft controller. (apache#12998) KAFKA-14570: Fix parenthesis in verifyFullFetchResponsePartitions output (apache#13072) MINOR: Remove public mutable fields from ProducerAppendInfo (apache#13091)
ijuma
reviewed
Jan 13, 2023
core/src/test/scala/unit/kafka/server/ReplicaAlterLogDirsThreadTest.scala
Show resolved
Hide resolved
Member
|
JDK 8 and 11 builds passed, 17 had 2 unrelated failures. |
Contributor
Author
Yes, good. Thanks. |
ijuma
added a commit
to confluentinc/kafka
that referenced
this pull request
Jan 17, 2023
…master * apache-github/trunk: (23 commits) MINOR: Include the inner exception stack trace when re-throwing an exception (apache#12229) MINOR: Fix docs to state that sendfile implemented in `TransferableRecords` instead of `MessageSet` (apache#13109) Update ProducerConfig.java (apache#13115) KAFKA-14618; Fix off by one error in snapshot id (apache#13108) KAFKA-13709 (follow-up): Avoid mention of 'exactly-once delivery' or 'delivery guarantees' in Connect (apache#13106) KAFKA-14367; Add `TxnOffsetCommit` to the new `GroupCoordinator` interface (apache#12901) KAFKA-14568: Move FetchDataInfo and related to storage module (apache#13085) KAFKA-14612: Make sure to write a new topics ConfigRecords to metadata log iff the topic is created (apache#13104) KAFKA-14601: Improve exception handling in KafkaEventQueue apache#13089 KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface (apache#12886) KAFKA-14530: Check state updater more often (apache#13017) KAFKA-14304 Use boolean for ZK migrating brokers in RPC/record (apache#13103) KAFKA-14003 Kafka Streams JUnit4 to JUnit5 migration part 2 (apache#12301) KAFKA-14607: Move Scheduler/KafkaScheduler to server-common (apache#13092) KAFKA-14367; Add `OffsetFetch` to the new `GroupCoordinator` interface (apache#12870) KAFKA-14557; Lock metadata log dir (apache#13058) MINOR: Implement toString method for TopicAssignment and PartitionAssignment (apache#13101) KAFKA-12558: Do not prematurely mutate internal partition state in Mirror Maker 2 (apache#11818) KAFKA-14540: Fix DataOutputStreamWritable#writeByteBuffer (apache#13032) KAFKA-14600: Reduce flakiness in ProducerIdExpirationTest (apache#13087) ...
guozhangwang
pushed a commit
to guozhangwang/kafka
that referenced
this pull request
Jan 25, 2023
…#13085) Part of KAFKA-14470: Move log layer to storage module. Reviewers: Ismael Juma <ismael@juma.me.uk> Co-authored-by: Ismael Juma <ismael@juma.me.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of KAFKA-14470: Move log layer to storage module.