Skip to content

KAFKA-15062: Adding ppc64le build stage#13817

Closed
Vaibhav-Nazare wants to merge 51 commits intoapache:trunkfrom
Vaibhav-Nazare:trunk
Closed

KAFKA-15062: Adding ppc64le build stage#13817
Vaibhav-Nazare wants to merge 51 commits intoapache:trunkfrom
Vaibhav-Nazare:trunk

Conversation

@Vaibhav-Nazare
Copy link

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@Vaibhav-Nazare
Copy link
Author

@dajac Can you check the please check the PR.

@divijvaidya
Copy link
Member

Hi @Vaibhav-Nazare
It was intentionally disabled in the past since the infrastructure was flaky #12380
If we want to officially test and support this platform, I would suggest that you start a KIP similar to https://cwiki.apache.org/confluence/display/KAFKA/KIP-826%3A+Define+platforms+supported and initiate a discussion in the community about it.

@Vaibhav-Nazare
Copy link
Author

Hi @divijvaidya
Thanks for the information, will start a KIP.

Also FYI new power VMs are created/managed by ASF infra and much more stable
https://issues.apache.org/jira/browse/INFRA-24663

@Vaibhav-Nazare
Copy link
Author

Vaibhav-Nazare commented Jun 19, 2023

Hi @divijvaidya
I have created the KIP https://cwiki.apache.org/confluence/display/KAFKA/KIP-942%3A+Add+Power%28ppc64le%29+support
Please let us know the further path forward.

@divijvaidya
Copy link
Member

Hey @Vaibhav-Nazare
The next step us to start a [DISCUSS] thread in the mailing list where the community can have a discussion on the KIP. The process of starting a KIP is mentioned here: https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals#KafkaImprovementProposals-Process

@Vaibhav-Nazare
Copy link
Author

HI @divijvaidya Thanks for the information , I have created a discussion thread for the KIP as per given process
https://lists.apache.org/thread/y62m18k5bgsbcmkw2f80vwnj2vjgy7nz

@Vaibhav-Nazare
Copy link
Author

Hi @divijvaidya any further updates for us?

@divijvaidya
Copy link
Member

Hey @Vaibhav-Nazare
A KIP needs at least 3 committer votes and I believe we haven't heard from other folks in the community on the KIP. I am waiting for others to chime in. Otherwise, we can start a vote in 2 weeks (and hope that the KIP gets at least 3 votes).

@divijvaidya divijvaidya added the kip Requires or implements a KIP label Jun 27, 2023
@Vaibhav-Nazare
Copy link
Author

Hi @divijvaidya Any further updates on nightly job enablement?

@Vaibhav-Nazare
Copy link
Author

Hi @cmccabe @mimaison @divijvaidya Any further updates on nightly job enablement?

@mimaison
Copy link
Member

mimaison commented Jul 20, 2023

@Vaibhav-Nazare The KIP needs to be voted. So far you've only started a discussion. I'd recommend replying to the discussion thread to ask for any more feedback, otherwise you can start a vote in the next few days. See https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals for the process

@Vaibhav-Nazare
Copy link
Author

Hi @mimaison @cmccabe If you agree can we have your votes too on the KIP please, @divijvaidya has already voted.

@Vaibhav-Nazare
Copy link
Author

Vaibhav-Nazare commented Sep 21, 2023

Hi @divijvaidya @mimaison @cmccabe can we look into this PR as the KIP-942 has been adopted

@Vaibhav-Nazare
Copy link
Author

Hi @divijvaidya @mimaison @cmccabe any updates on how we want to proceed?

@mimaison
Copy link
Member

mimaison commented Oct 9, 2023

Thanks @Vaibhav-Nazare for the KP and PR.

I've not looked at Jenkinsfiles in a while, can you clarify why you used nested stage fields unlike the other existing platforms?

@Vaibhav-Nazare
Copy link
Author

Hi @mimaison, thanks for the reply.
We were referring to older Jenkins file before the support was disabled on Power, No specific reason to use nested stage fields.

If any modification is required, would do it according to accepted and correct ways, please do let me know.

@mimaison
Copy link
Member

mimaison commented Mar 7, 2024

Sorry for the delay. I tried building your branch and it fails with:

Scripts not permitted to use method org.jenkinsci.plugins.workflow.support.steps.build.RunWrapper getRawBuild

See https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14717/8/pipeline/14

I tried a few things to fix the expression in my branch. It seems I'm getting close to run but I'm not sure it will do what we want. Reading the docs for when if seems to simply be a condition for the build to run, not a trigger. So if I understand correctly with the current change the PowerPC stage would run on any PRs opened/updated between 10am-11am. This is different than building trunk daily at 10am.

@Vaibhav-Nazare
Copy link
Author

Thanks @mimaison for looking into at, so seems we are out of options to build the specific stage daily, what if we add an additional jenkins file just to build for ppc64le something like Jenkinsfile.ppc64le in that way we can have the cron job which you mentioned previously would work just some thoughts from my end

@mimaison
Copy link
Member

mimaison commented Mar 7, 2024

Yeah that seems like the next best approach. However I have no idea how to set that up. If you know how to set that up, go ahead and update the PR otherwise you'll probably will have to ask on the dev mailing list to see if anyone is familiar with this type of setup.

@Vaibhav-Nazare
Copy link
Author

Hi @mimaison additional jenkinsfile for ppc64le has been added , also as per my understanding some changes would be required at https://ci-builds.apache.org/job/Kafka/job/kafka/ to have a new job configured for ppc64le

@mimaison
Copy link
Member

I don't think (at least don't know how) we can modify the jobs in Jenkins directly. The jobs are automatically created via the Jenkinsfile in this repository. I see some other Apache projects have multiple Jenkinsjob files, it would be good to understand how it works.

@Vaibhav-Nazare
Copy link
Author

I have created a JIRA to have the new job configured https://issues.apache.org/jira/browse/INFRA-25631

@Vaibhav-Nazare
Copy link
Author

@mimaison can you have a loot at it once at the JIRA mentioned in previous comment

@mimaison
Copy link
Member

Instead of directly asking Infra, I think asking on the dev list first might have been better as suggested above.

@Vaibhav-Nazare
Copy link
Author

Yes I would have followed the same , I have started a discussing on dev list.
https://lists.apache.org/thread/f3yj7o5nfskz1onr59kmodm73kvtsktk

@Vaibhav-Nazare
Copy link
Author

@divijvaidya can you also have a look at this once https://lists.apache.org/thread/f3yj7o5nfskz1onr59kmodm73kvtsktk

@mimaison mimaison mentioned this pull request Apr 22, 2024
3 tasks
@Vaibhav-Nazare
Copy link
Author

Hi @mimaison seems no discussion happening on the mailing list, Just a query as per the reply on the jira issue which I raised as per the comment a committer has access to enable job any time , so may be can you look into it.

@Vaibhav-Nazare
Copy link
Author

HI @mimaison what can we do to get this going, as there is no response in the discussion.

@github-actions
Copy link

github-actions bot commented Jan 3, 2025

This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

@github-actions github-actions bot added the stale Stale PRs label Jan 3, 2025
@github-actions
Copy link

github-actions bot commented Feb 3, 2025

This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.

@github-actions github-actions bot added the closed-stale PRs that were closed due to inactivity label Feb 3, 2025
@github-actions github-actions bot closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

closed-stale PRs that were closed due to inactivity kip Requires or implements a KIP stale Stale PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants