KAFKA-15834: Remove NamedTopologyIntegrationTest which leaks clients #15185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Greg Harris <greg.harris@aiven.io>
Contributor
Author
|
Hey @mjsax @ableegoldman thanks for the context on the Jira ticket. I removed just the leaky test, instead of the whole suite, but let me know if you think the whole suite should be eliminated. Thanks! |
Signed-off-by: Greg Harris <greg.harris@aiven.io>
3 tasks
Member
|
Not sure. Leave it up to @ableegoldman to sign off and make a call. |
Contributor
Author
|
Build succeeded in CI, and test failures appear unrelated. |
dajac
pushed a commit
to dajac/kafka
that referenced
this pull request
Jan 19, 2024
…ents (apache#15185) Signed-off-by: Greg Harris <greg.harris@aiven.io> Reviewers: Anna Sophie Blee-Goldman <sophie@responsive.dev>, Matthias J. Sax <matthias@confluent.io>
showuon
pushed a commit
to showuon/kafka
that referenced
this pull request
Jan 22, 2024
…ents (apache#15185) Signed-off-by: Greg Harris <greg.harris@aiven.io> Reviewers: Anna Sophie Blee-Goldman <sophie@responsive.dev>, Matthias J. Sax <matthias@confluent.io>
3 tasks
yyu1993
pushed a commit
to yyu1993/kafka
that referenced
this pull request
Feb 15, 2024
…ents (apache#15185) Signed-off-by: Greg Harris <greg.harris@aiven.io> Reviewers: Anna Sophie Blee-Goldman <sophie@responsive.dev>, Matthias J. Sax <matthias@confluent.io>
clolov
pushed a commit
to clolov/kafka
that referenced
this pull request
Apr 5, 2024
…ents (apache#15185) Signed-off-by: Greg Harris <greg.harris@aiven.io> Reviewers: Anna Sophie Blee-Goldman <sophie@responsive.dev>, Matthias J. Sax <matthias@confluent.io>
Phuc-Hong-Tran
pushed a commit
to Phuc-Hong-Tran/kafka
that referenced
this pull request
Jun 6, 2024
…ents (apache#15185) Signed-off-by: Greg Harris <greg.harris@aiven.io> Reviewers: Anna Sophie Blee-Goldman <sophie@responsive.dev>, Matthias J. Sax <matthias@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test leaks Kafka clients, because the underlying consumer gets stuck trying to read from a non-existent topic.
Rather than change the client behavior in this situation, or change the way streams handles blocked threads, remove this test which causes the leak because the test itself is low-value.
Committer Checklist (excluded from commit message)