Skip to content

Conversation

@gharris1727
Copy link
Contributor

These tests leak resources intermittently, so I didn't catch them in #15185:

shouldWaitForMissingInputTopicsToBeCreated:
at org.apache.kafka.streams.processor.internals.namedtopology.KafkaStreamsNamedTopologyWrapper.<init>(KafkaStreamsNamedTopologyWrapper.java:84)
at org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.setupSecondKafkaStreams(NamedTopologyIntegrationTest.java:239)
at org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldWaitForMissingInputTopicsToBeCreated(NamedTopologyIntegrationTest.java:721)
shouldRemoveOneNamedTopologyWhileAnotherContinuesProcessing:
at org.apache.kafka.streams.processor.internals.namedtopology.KafkaStreamsNamedTopologyWrapper.<init>(KafkaStreamsNamedTopologyWrapper.java:84)
at org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.setup(NamedTopologyIntegrationTest.java:224)
shouldBackOffTaskAndEmitDataWithinSameTopology:
at org.apache.kafka.streams.processor.internals.namedtopology.KafkaStreamsNamedTopologyWrapper.<init>(KafkaStreamsNamedTopologyWrapper.java:80)
at org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldBackOffTaskAndEmitDataWithinSameTopology(NamedTopologyIntegrationTest.java:785)

I haven't observed the other tests in this suite fail, but that doesn't mean they don't have leaks.
The leaks do all seem to follow the same pattern: the close(Duration) calls time out, leaving behind resources. You can see these failures in #14783.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

… that contain resource leaks

Signed-off-by: Greg Harris <greg.harris@aiven.io>
@gharris1727
Copy link
Contributor Author

Hey @ableegoldman I missed some of the tests in this suite, so I had to open a follow-up. Thanks!

Copy link
Member

@ableegoldman ableegoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok with me

Signed-off-by: Greg Harris <greg.harris@aiven.io>
@gharris1727 gharris1727 force-pushed the kafka-16087-more-leaky-namedtopologytest branch from f13d8df to c45345f Compare January 29, 2024 21:13
@gharris1727
Copy link
Contributor Author

Test failures appear unrelated.

@gharris1727 gharris1727 changed the title KAFKA-16087: Remove more leaky NamedTopologyIntegrationTest tests KAFKA-15834: Remove more leaky NamedTopologyIntegrationTest tests Feb 5, 2024
@gharris1727 gharris1727 merged commit 5f35b41 into apache:trunk Feb 5, 2024
yyu1993 pushed a commit to yyu1993/kafka that referenced this pull request Feb 15, 2024
…ache#15243)

Signed-off-by: Greg Harris <greg.harris@aiven.io>
Reviewers: Anna Sophie Blee-Goldman <sophie@responsive.dev>
clolov pushed a commit to clolov/kafka that referenced this pull request Apr 5, 2024
…ache#15243)

Signed-off-by: Greg Harris <greg.harris@aiven.io>
Reviewers: Anna Sophie Blee-Goldman <sophie@responsive.dev>
Phuc-Hong-Tran pushed a commit to Phuc-Hong-Tran/kafka that referenced this pull request Jun 6, 2024
…ache#15243)

Signed-off-by: Greg Harris <greg.harris@aiven.io>
Reviewers: Anna Sophie Blee-Goldman <sophie@responsive.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

streams tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants