Skip to content

MINOR: Move candidateClients set creation outside of task loop for StickyTaskAssignor #19511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

MINOR: Move candidateClients set creation outside of task loop for StickyTaskAssignor #19511

merged 1 commit into from
Apr 30, 2025

Conversation

lorcanj
Copy link
Contributor

@lorcanj lorcanj commented Apr 18, 2025 •
edited by github-actions bot
Loading

This PR moves the computation of the "client list", which is the same
for all tasks, out of the loop, to avoid unnecessary re-computation.

Reviewers: Matthias J. Sax matthias@confluent.io

@github-actions github-actions bot added triage PRs from the community streams small Small PRs labels Apr 18, 2025
@lorcanj lorcanj changed the title MINOR: move candidateClients set creation outside of task loop MINOR: move candidateClients set creation outside of task loop for StickyTaskAssignor Apr 18, 2025
@lorcanj lorcanj changed the title MINOR: move candidateClients set creation outside of task loop for StickyTaskAssignor MINOR: Move candidateClients set creation outside of task loop for StickyTaskAssignor Apr 18, 2025
@github-actions GitHub Actions
Copy link

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

mjsax
mjsax approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member

@mjsax mjsax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Makes sense to me.

@mjsax mjsax removed the triage PRs from the community label Apr 30, 2025
@mjsax mjsax merged commit 009fc7c into apache:trunk Apr 30, 2025
27 checks passed
@mjsax
Copy link
Member

mjsax commented Apr 30, 2025

Thanks for the PR. Merged to trunk.

shmily7829 pushed a commit to shmily7829/kafka that referenced this pull request May 7, 2025
@lorcanj @shmily7829
MINOR: Move candidateClients set creation outside of task loop for St…
9548362 
…ickyTaskAssignor (apache#19511)

This PR moves the computation of the "client list", which is the same
for all tasks,  out of the loop, to avoid unnecessary re-computation.

Reviewers: Matthias J. Sax <matthias@confluent.io>
@lorcanj lorcanj deleted the move-set-creation-outside-of-loop branch May 19, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjsax mjsax mjsax approved these changes

Assignees
No one assigned
Labels
ci-approved small Small PRs streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorcanj @mjsax