MINOR: Move candidateClients set creation outside of task loop for StickyTaskAssignor #19511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorcanj
changed the title
lorcanj
changed the title
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
mjsax
approved these changes
Apr 30, 2025
Member
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
Thanks for the PR. Makes sense to me.
Member
|
Thanks for the PR. Merged to |
shmily7829
pushed a commit
to shmily7829/kafka
that referenced
this pull request
May 7, 2025
…ickyTaskAssignor (apache#19511) This PR moves the computation of the "client list", which is the same for all tasks, out of the loop, to avoid unnecessary re-computation. Reviewers: Matthias J. Sax <matthias@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the computation of the "client list", which is the same
for all tasks, out of the loop, to avoid unnecessary re-computation.
Reviewers: Matthias J. Sax matthias@confluent.io