Skip to content

MINOR: Move candidateClients set creation outside of task loop for StickyTaskAssignor #19511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -178,10 +178,10 @@ private static void assignActive(final ApplicationState applicationState,
// assign any remaining unassigned tasks
final List<TaskId> sortedTasks = new ArrayList<>(unassigned);
Collections.sort(sortedTasks);
for (final TaskId taskId : sortedTasks) {
final Set<ProcessId> candidateClients = clients.stream()
final Set<ProcessId> candidateClients = clients.stream()
.map(KafkaStreamsState::processId)
.collect(Collectors.toSet());
for (final TaskId taskId : sortedTasks) {
final ProcessId bestClient = assignmentState.findBestClientForTask(taskId, candidateClients);
assignmentState.finalizeAssignment(taskId, bestClient, AssignedTask.Type.ACTIVE);
}