KAFKA-19178: Replace Vector by ArrayList for PluginClassLoader#getResources #19529
Conversation
FrankYang0529
left a comment
FrankYang0529
left a comment
There was a problem hiding this comment.
Thanks for the PR. Could you also refactor Vector as ArrayList in
Thanks.
@FrankYang0529 Thanks for the suggestion! I just have one concern — in our current test setup,both the |
|
@Rancho-7 the returned type |
|
Since this change will only affect the test scenarios and to maintain consistency in the code, I believe replacing it with |
| */ | ||
| public static void addACLs(String principal, AclBinding aclBinding) { | ||
| Vector<AclBinding> aclBindings = FakeLocalMetadataStore.ALL_ACLS.getOrDefault(principal, new Vector<>()); | ||
| List<AclBinding> aclBindings = FakeLocalMetadataStore.ALL_ACLS.getOrDefault(principal, new ArrayList<>()); |
There was a problem hiding this comment.
that is interesting. It seems those methods should be thread-safe, but it isn't. Could you please revert those changes and then open a jira for it?
There was a problem hiding this comment.
opened https://issues.apache.org/jira/browse/KAFKA-19196 to track this.
5 participants
jira: https://issues.apache.org/jira/browse/KAFKA-19178
The vector is a synchronized collection, and in the case we don't need
to sync. Also, we can use
Collections.enumerationto convertcollection to enumeration easily.
Reviewers: PoAn Yang payang@apache.org, Ken Huang
s7133700@gmail.com, Chia-Ping Tsai chia7712@gmail.com