Skip to content

KAFKA-19178: Replace Vector by ArrayList for PluginClassLoader#getResources #19529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chia7712 merged 6 commits into from
Apr 26, 2025
Merged

KAFKA-19178: Replace Vector by ArrayList for PluginClassLoader#getResources #19529

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aac0d66
KAFKA-19178: Replace Vector by ArrayList
Rancho-7 Apr 21, 2025
b1bde10
Merge branch 'upstream-trunk' into KAFKA-19178
Rancho-7 Apr 23, 2025
f85ddec
Merge branch 'upstream-trunk' into KAFKA-19178
Rancho-7 Apr 24, 2025
02cef9e
replace Vector with ArrayList
Rancho-7 Apr 24, 2025
04591a1
Merge branch 'upstream-trunk' into KAFKA-19178
Rancho-7 Apr 24, 2025
34208e2
revert
Rancho-7 Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ...t/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginClassLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,11 @@
import java.io.IOException;
import java.net.URL;
import java.net.URLClassLoader;
import java.util.ArrayList;
import java.util.Collections;
import java.util.Enumeration;
import java.util.List;
import java.util.Objects;
import java.util.Vector;

/**
* A custom classloader dedicated to loading Connect plugin classes in classloading isolation.
Expand Down Expand Up @@ -87,7 +89,7 @@ public URL getResource(String name) {
@Override
public Enumeration<URL> getResources(String name) throws IOException {
Objects.requireNonNull(name);
Vector<URL> resources = new Vector<>();
List<URL> resources = new ArrayList<>();
for (Enumeration<URL> foundLocally = findResources(name); foundLocally.hasMoreElements();) {
URL url = foundLocally.nextElement();
if (url != null)
Expand All @@ -99,7 +101,7 @@ public Enumeration<URL> getResources(String name) throws IOException {
if (url != null)
resources.add(url);
}
return resources.elements();
return Collections.enumeration(resources);
}

// This method needs to be thread-safe because it is supposed to be called by multiple
Expand Down