MINOR: Run CI with Java 24 #20295
MINOR: Run CI with Java 24 #20295
Conversation
github-actions
bot
added
triage
srdo
force-pushed
the
java-24-build-no-spotbugs
branch
from
a222ae8 to
28ee92b
Compare
This commit updates CI to test against Java 24 instead of Java 23 which is EOL. Due to Spotbugs not having released version 4.9.4 yet, we can't run Spotbugs on Java 24. Instead, we are choosing to run Spotbugs, and the rest of the compile and validate build step, on Java 17 for now. Once 4.9.4 has released, we will switch to using Java 24 for this. Exclude spotbugs from the run-tests gradle action. Spotbugs is already being run once in the build by "compile and validate", there is no reason to run it again as part of executing tests.
srdo
force-pushed
the
java-24-build-no-spotbugs
branch
from
28ee92b to
1ad1bb9
Compare
|
The failures in the build scan steps are because (if I understand the Github docs at https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#workflow_run correctly) the ci-complete workflow executes based on the state of master, not the state of this branch. This means that until this is merged, the old version of ci-complete will be used, which is why those build steps still reference Java 23. It might have been better if ci-complete was called explicitly by edit: The use of So there's not much to do: This build will fail because it uses the master version of Once merged, this failure should go away. |
| -Pkafka.cluster.test.repeat=$TEST_REPEAT \ | ||
| -Pkafka.test.verbose=$TEST_VERBOSE \ | ||
| -PcommitId=xxxxxxxxxxxxxxxx \ | ||
| -x spotbugsMain \ |
There was a problem hiding this comment.
Building Kafka locally with JDK 24 still results in a SpotBugs error. Could you please update the build.gradle file to skip SpotBugs check based on the JDK version?
| "--add-opens=java.security.jgss/sun.security.krb5=ALL-UNNAMED" | ||
| ) | ||
|
|
||
| if (JavaVersion.current().isCompatibleWith(JavaVersion.VERSION_24)) { |
There was a problem hiding this comment.
open https://issues.apache.org/jira/browse/KAFKA-19580 to trace the spotbug upgrade.
| <th>Java 11</th> | ||
| <th>Java 17</th> | ||
| <th>Java 23</th> | ||
| <th>Java 24</th> |
There was a problem hiding this comment.
could you please revert this change? we don't run java 24 for 4.1 and 4.0 branch
This commit updates CI to test against Java 24 instead of Java 23 which is EOL. Due to Spotbugs not having released version 4.9.4 yet, we can't run Spotbugs on Java 24. Instead, we are choosing to run Spotbugs, and the rest of the compile and validate build step, on Java 17 for now. Once 4.9.4 has released, we will switch to using Java 24 for this. Exclude spotbugs from the run-tests gradle action. Spotbugs is already being run once in the build by "compile and validate", there is no reason to run it again as part of executing tests. Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
This commit updates CI to test against Java 24 instead of Java 23 which is EOL. Due to Spotbugs not having released version 4.9.4 yet, we can't run Spotbugs on Java 24. Instead, we are choosing to run Spotbugs, and the rest of the compile and validate build step, on Java 17 for now. Once 4.9.4 has released, we will switch to using Java 24 for this. Exclude spotbugs from the run-tests gradle action. Spotbugs is already being run once in the build by "compile and validate", there is no reason to run it again as part of executing tests. Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
This reverts commit 07179bf.
2 participants
This commit updates CI to test against Java 24 instead of Java 23 which
is EOL.
Due to Spotbugs not having released version 4.9.4 yet, we can't run
Spotbugs on Java 24. Instead, we are choosing to run Spotbugs, and the
rest of the compile and validate build step, on Java 17 for now.
Once 4.9.4 has released, we will switch to using Java 24 for this.
Exclude spotbugs from the run-tests gradle action. Spotbugs is already
being run once in the build by "compile and validate", there is no
reason to run it again as part of executing tests.
Reviewers: Chia-Ping Tsai chia7712@gmail.com