WIP: Test against Java 24 #19514
WIP: Test against Java 24 #19514
Conversation
github-actions
bot
added
triage
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
srdo
force-pushed
the
java-24-build
branch
2 times, most recently
from
60bee39 to
cac609d
Compare
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
|
Status: This passes tests locally. As Gradle 8.14 has released, the only remaining roadblock is that the currently-newest version of Spotbugs crashes the build. The underlying bug is fixed in the latest Spotbugs source, so once Spotbugs 4.9.4 is released (see spotbugs/spotbugs#3380 (comment)), this should be good to go. |
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
|
@srdo could you please rebase code and fix the conflicts? |
Upgrade Scala to 2.13.16, in order to get a Java 24-compatible ASM version. Upgrade Gradle to 8.14, which is the first Java 24 compatible version. Upgrade spotbugs to 4.9.4. This is the minimum version that's both Java 24 compatible, and not affected by spotbugs/spotbugs#3320 Since the new spotbugs version introduces some extra checks, this commit excludes those warnings, without looking at whether they are real issues or false positives. Fix gradle wrapper. The download-the-wrapper bit was inserted before the CLASSPATH line in the wrapper, because that referenced the jar. That line no longer mentions the jar, because the wrapper is referenced via -jar instead of -cp now. This means the download was placed in the middle of a java invocation command, breaking the script. It's been moved to be before the call to exec. It seems fair to assume that the script will only exec once, and that the exec call is going to call the wrapper.
|
@chia7712 Sure, rebased. But this won't be mergeable until the next Spotbugs release. |
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
|
@srdo could you please use spotbug 4.9.4 to trigger CI again? Thanks |
|
@chia7712 I would, but Spotbugs 4.9.4 has still not released. I'll update this PR as soon as they put out the new version. |
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
|
@chia7712 I don't know how far off a new spotbugs release is, and I'd rather not keep blocking on that. I was thinking we could cut this into 3 parts, where 2 can be merged immediately:
I think this is better than continuing to block everything, including being able to test against Java 24, on Spotbugs putting out a new release. |
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
3 participants
WIP: This PR still uses a Gradle 8.14 RC, and Spotbugs 4.9.4 has not
released yet, so testing it requires a local build.
Upgrade Scala to 2.13.16, in order to get a Java 24-compatible ASM
version.
Upgrade Gradle to 8.14, which is the first Java 24 compatible version.
Upgrade spotbugs to 4.9.4. This is the minimum version that's both Java
24 compatible, and not affected by
spotbugs/spotbugs#3320
Since the new spotbugs version introduces some extra checks, this commit
excludes those warnings, without looking at whether they are real issues
or false positives.
Addressing those warnings is left as future work, since the code is no
worse now than before the issues were highlighted.