-
Notifications
You must be signed in to change notification settings - Fork 14.8k
MINOR: Run CI with Java 24 and update documentation (instead of 23) #19235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like Java 24 isn't available yet. Is that right @mumrah or is there something else we must do to make Java 24 available? |
|
It seems that Gradle does not support Java 24 yet. https://docs.gradle.org/current/userguide/compatibility.html |
|
It seems the gradle team is still working on it. |
|
@ijuma yea it looks like |
|
I was looking at doing this too, and want to share a few changes in case it saves you work: You likely need to upgrade to Scala 2.13.16 https://github.com/apache/kafka/compare/trunk...srdo:kafka:java-24-build?expand=1#diff-a74b4a65ab1f4aed61344787bb9654ba7e835154730653848c88ca11f9965dc0R250 You will also likely need to upgrade Spotbugs to the latest version https://github.com/apache/kafka/compare/trunk...srdo:kafka:java-24-build?expand=1#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7R42 Since Spotbugs has introduced new warning types, you may need to add some exclusions https://github.com/apache/kafka/compare/trunk...srdo:kafka:java-24-build?expand=1#diff-359c6969c92e0b25bb854c49e9d08391af4a17a7019450b123d473ba318ad3d4 until someone can investigate the potential bugs. |
|
@srdo Feel free to submit your own PR if you're further along - I can then close this one. |
|
@ijuma I just have the bits I linked above, which is how far I got before getting roadblocked by Gradle. Feel free to use those bits if they're helpful for this PR. If not, that's fine too :) |
|
Raised #19514, as you suggested. It includes the commit from this PR, and updates some dependencies to get the build working. It's still blocked by Gradle not having released a Java 24-compatible version, and Spotbugs turns out to have an issue that requires them to release a new version as well. Once they release, I'll update that PR. |
|
This PR is being marked as stale since it has not had any activity in 90 days. If you If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact). If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. |
|
This PR has been closed since it has not had any activity in 120 days. If you feel like this |
No description provided.