Skip to content

Conversation

@ijuma
Copy link
Member

@ijuma ijuma commented Mar 19, 2025

No description provided.

@github-actions github-actions bot added build Gradle build or GitHub Actions small Small PRs labels Mar 19, 2025
@ijuma
Copy link
Member Author

ijuma commented Mar 19, 2025

Looks like Java 24 isn't available yet. Is that right @mumrah or is there something else we must do to make Java 24 available?

@m1a2st
Copy link
Collaborator

m1a2st commented Mar 19, 2025

It seems that Gradle does not support Java 24 yet. https://docs.gradle.org/current/userguide/compatibility.html

@frankvicky
Copy link
Contributor

It seems the gradle team is still working on it.
gradle/gradle#32576

@mumrah
Copy link
Member

mumrah commented Mar 19, 2025

@ijuma yea it looks like setup-java could not find an image for temurin 24. I guess we'll need to wait for that as well as Gradle to ship support for 24. I expect it won't take very long.

@srdo
Copy link
Contributor

srdo commented Mar 28, 2025

I was looking at doing this too, and want to share a few changes in case it saves you work:

You likely need to upgrade to Scala 2.13.16 https://github.com/apache/kafka/compare/trunk...srdo:kafka:java-24-build?expand=1#diff-a74b4a65ab1f4aed61344787bb9654ba7e835154730653848c88ca11f9965dc0R250

You will also likely need to upgrade Spotbugs to the latest version https://github.com/apache/kafka/compare/trunk...srdo:kafka:java-24-build?expand=1#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7R42

Since Spotbugs has introduced new warning types, you may need to add some exclusions https://github.com/apache/kafka/compare/trunk...srdo:kafka:java-24-build?expand=1#diff-359c6969c92e0b25bb854c49e9d08391af4a17a7019450b123d473ba318ad3d4 until someone can investigate the potential bugs.

@ijuma
Copy link
Member Author

ijuma commented Mar 28, 2025

@srdo Feel free to submit your own PR if you're further along - I can then close this one.

@srdo
Copy link
Contributor

srdo commented Mar 28, 2025

@ijuma I just have the bits I linked above, which is how far I got before getting roadblocked by Gradle. Feel free to use those bits if they're helpful for this PR. If not, that's fine too :)

@srdo
Copy link
Contributor

srdo commented Apr 18, 2025

Raised #19514, as you suggested. It includes the commit from this PR, and updates some dependencies to get the build working.

It's still blocked by Gradle not having released a Java 24-compatible version, and Spotbugs turns out to have an issue that requires them to release a new version as well. Once they release, I'll update that PR.

@github-actions
Copy link

This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

@github-actions github-actions bot added the stale Stale PRs label Jul 18, 2025
@github-actions
Copy link

This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.

@github-actions github-actions bot added the closed-stale PRs that were closed due to inactivity label Aug 18, 2025
@github-actions github-actions bot closed this Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Gradle build or GitHub Actions closed-stale PRs that were closed due to inactivity small Small PRs stale Stale PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants