MINOR: improve RLMQuotaMetricsTest #20425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
chia7712
reviewed
Aug 28, 2025
| // Register the sensor | ||
| quotaMetrics.sensor(); | ||
| var avg = metrics.metricName("metric" + "-avg", "group", String.format("format", "average")); | ||
| var avg = metrics.metricName("metric" + "-avg", "group", "average"); |
Member
There was a problem hiding this comment.
I guess it was intended to test the description format. Perhaps we could add such a test. for example:
RLMQuotaMetrics quotaMetrics = new RLMQuotaMetrics(metrics, "metric", "group", "this is %s", 5);
// Register the sensor
quotaMetrics.sensor();
var avg = metrics.metricName("metric" + "-avg", "group", "this is average");
// Verify that metrics are created
var result = metrics.metric(avg);
assertNotNull(result);
assertEquals(result.metricName().description(), avg.description());
mjsax
changed the title
chia7712
approved these changes
Aug 29, 2025
eduwercamacaro
pushed a commit
to littlehorse-enterprises/kafka
that referenced
this pull request
Nov 12, 2025
Adds metrics description verification to RLMQuotaMetricsTest. Reviewers: Ken Huang <s7133700@gmail.com>, TengYao Chi <kitingiao@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds metrics description verification to RLMQuotaMetricsTest.
Reviewers: Ken Huang s7133700@gmail.com, TengYao Chi
kitingiao@gmail.com, Chia-Ping Tsai chia7712@gmail.com