Skip to content

MINOR: improve RLMQuotaMetricsTest #20425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chia7712 merged 2 commits into from
Aug 29, 2025
Merged

MINOR: improve RLMQuotaMetricsTest #20425

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67f7c5e
MINOR: cleanup String.format
mjsax Aug 28, 2025
4ee05e4
review comments
mjsax Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions storage/src/test/java/org/apache/kafka/server/log/remote/quota/RLMQuotaMetricsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,16 @@ public void testNewSensorWhenExpired() {

@Test
public void testClose() {
RLMQuotaMetrics quotaMetrics = new RLMQuotaMetrics(metrics, "metric", "group", "format", 5);
RLMQuotaMetrics quotaMetrics = new RLMQuotaMetrics(metrics, "metric", "group", "this is %s", 5);

// Register the sensor
quotaMetrics.sensor();
var avg = metrics.metricName("metric" + "-avg", "group", String.format("format", "average"));
var avg = metrics.metricName("metric" + "-avg", "group", "this is average");

// Verify that metrics are created
assertNotNull(metrics.metric(avg));
var result = metrics.metric(avg);
assertNotNull(result);
assertEquals(result.metricName().description(), avg.description());

// Close the quotaMetrics instance
quotaMetrics.close();
Expand Down