fix: georadius should return empty set if the key does not exist (#845)

apache · Sep 11, 2022 · fa01b03 · fa01b03
1 parent 8a206b8
commit fa01b03
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/redis_geo.cc b/src/redis_geo.cc
@@ -97,7 +97,7 @@ rocksdb::Status Geo::Radius(const Slice &user_key,
   AppendNamespacePrefix(user_key, &ns_key);
   ZSetMetadata metadata(false);
   rocksdb::Status s = ZSet::GetMetadata(ns_key, &metadata);
-  if (!s.ok()) return s;
+  if (!s.ok()) return s.IsNotFound() ? rocksdb::Status::OK() : s;
 
   /* Get all neighbor geohash boxes for our radius search */
   GeoHashRadius georadius = GeoHashHelper::GetAreasByRadiusWGS84(longitude, latitude, radius_meters);

diff --git a/tests/tcl/tests/unit/geo.tcl b/tests/tcl/tests/unit/geo.tcl
@@ -319,6 +319,11 @@ start_server {tags {"geo"}} {
         set e
     } {*syntax*}
 
+    test {GEORADIUS missing key} {
+        r del points
+        assert_equal {} [r georadius points 13.361389 38.115556 50 km]
+    }
+
     # test {GEOSEARCHSTORE STORE option: syntax error} {
     #     catch {r geosearchstore abc points fromlonlat 13.361389 38.115556 byradius 50 km store abc} e
     #     set e