Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: georadius should return empty set if the key does not exist #845

Merged
merged 1 commit into from
Sep 11, 2022
Merged

fix: georadius should return empty set if the key does not exist #845

merged 1 commit into from
Sep 11, 2022

Conversation

ColinChamber
Copy link
Contributor

@ColinChamber ColinChamber commented Sep 10, 2022 •
edited by git-hulk
Loading

Closes #844

git-hulk
git-hulk approved these changes Sep 11, 2022
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ColinChamber

@tisonkun tisonkun changed the title Fix georadius return ERR NotFound when the key does not exist. fix: georadius should return empty set if the key does not exist Sep 11, 2022
@tisonkun tisonkun merged commit fa01b03 into apache:unstable Sep 11, 2022
suica pushed a commit to suica/incubator-kvrocks that referenced this pull request Sep 11, 2022
@ColinChamber @suica
fix: georadius should return empty set if the key does not exist (apa…
3bb96c7 
…che#845)
@tanruixiang tanruixiang mentioned this pull request Oct 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When the key does not exist, the return value of georadius is inconsistent with that of Redis.
3 participants
@ColinChamber @git-hulk @tisonkun