Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect regex to get cmake version #1042

Closed
2 tasks done
tanruixiang opened this issue Oct 25, 2022 · 0 comments · Fixed by #1043
Closed
2 tasks done

Incorrect regex to get cmake version #1042

tanruixiang opened this issue Oct 25, 2022 · 0 comments · Fixed by #1043
Assignees
@tisonkun
Labels
bug type bug

Comments

@tanruixiang
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar issues.

Version

a1bb45d

Minimal reproduce step

The latest version of cmake is cmake-3.25.0-rc2. The existing regular expression will parse it incorrectly as 3.25.02.

What did you expect to see?

Parse it as 3.25.0.

What did you see instead?

Parse it as 3.25.02.

Anything Else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@tanruixiang tanruixiang added the bug type bug label Oct 25, 2022
@tisonkun tisonkun self-assigned this Oct 25, 2022
tisonkun added a commit to tisonkun/incubator-kvrocks that referenced this issue Oct 25, 2022
@tisonkun
fix: properly parse cmake version
2c2c9ce 
This closes apache#1042.

Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun mentioned this issue Oct 25, 2022
Merged
tisonkun added a commit that referenced this issue Oct 25, 2022
@tisonkun
fix: properly parse cmake version (#1043)
e0fc532 
This closes #1042.

Signed-off-by: tison <wander4096@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tisonkun tisonkun

Labels
bug type bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: properly parse cmake version tisonkun/incubator-kvrocks
2 participants
@tisonkun @tanruixiang