Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly parse cmake version #1043

Merged
merged 1 commit into from
Oct 25, 2022
Merged

fix: properly parse cmake version #1043

merged 1 commit into from
Oct 25, 2022

Conversation

tisonkun
Copy link
Member

This closes #1042.

cc @tanruixiang you can try out whether this patch fixes your issue.

@tisonkun
fix: properly parse cmake version
2c2c9ce 
This closes apache#1042.

Signed-off-by: tison <wander4096@gmail.com>
tanruixiang
tanruixiang approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@tanruixiang tanruixiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good patch, much better than what I wrote with sed.

@tisonkun tisonkun merged commit e0fc532 into apache:unstable Oct 25, 2022
@tisonkun tisonkun deleted the properly-parse-cmake-version branch October 25, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanruixiang tanruixiang tanruixiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect regex to get cmake version
2 participants
@tisonkun @tanruixiang