Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] TestKeyspace.Type_a_expired_key failed #2091

Closed
1 of 2 tasks
mapleFU opened this issue Feb 7, 2024 · 0 comments · Fixed by #2104
Closed
1 of 2 tasks

[CI] TestKeyspace.Type_a_expired_key failed #2091

mapleFU opened this issue Feb 7, 2024 · 0 comments · Fixed by #2104
Assignees
@git-hulk
Labels
bug type bug

Comments

@mapleFU
Copy link
Member

mapleFU commented Feb 7, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

Version

master

Minimal reproduce step

See: https://github.com/apache/kvrocks/actions/runs/7813343348/job/21312734346

What did you expect to see?

CI passed

What did you see instead?

failed

Anything Else?

no

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@mapleFU mapleFU added the bug type bug label Feb 7, 2024
@git-hulk git-hulk self-assigned this Feb 17, 2024
@git-hulk git-hulk mentioned this issue Feb 17, 2024
Merged
git-hulk added a commit that referenced this issue Feb 17, 2024
@git-hulk
Fix flaky test cases in keyspace_test.go (#2104)
e8c05a3 
We expired a key with 1 second which is too short for testing the expiration time,
because `Metadata::ExpireMsToS` function will use rounding to get a closer time value if
METADATA_64BIT_ENCODING_MASK was disabled.

This closes #2091
JoverZhang pushed a commit to JoverZhang/kvrocks that referenced this issue Feb 24, 2024
@git-hulk @JoverZhang
Fix flaky test cases in keyspace_test.go (apache#2104)
323e628 
We expired a key with 1 second which is too short for testing the expiration time,
because `Metadata::ExpireMsToS` function will use rounding to get a closer time value if
METADATA_64BIT_ENCODING_MASK was disabled.

This closes apache#2091
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@git-hulk git-hulk

Labels
bug type bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flaky test cases in keyspace_test.go git-hulk/kvrocks
2 participants
@git-hulk @mapleFU