Fix flaky test cases in keyspace_test.go #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We expired a key with 1 second which is too short for testing the expiration time, because Metadata::ExpireMsToS function will use rounding to get a closer time value if METADATA_64BIT_ENCODING_MASK was enabled.
I think this function will not be used in the 64bit encoding mode? |
PragmaTwice
approved these changes
Feb 17, 2024
Yes, it's a typo in the comments. Should be disabled instead of the enabled. |
|
torwig
approved these changes
Feb 17, 2024
JoverZhang
pushed a commit
to JoverZhang/kvrocks
that referenced
this pull request
Feb 24, 2024
We expired a key with 1 second which is too short for testing the expiration time, because `Metadata::ExpireMsToS` function will use rounding to get a closer time value if METADATA_64BIT_ENCODING_MASK was disabled. This closes apache#2091
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expired a key with 1 second which is too short for testing the expiration time,
because
Metadata::ExpireMsToSfunction will use rounding to get a closer time value ifMETADATA_64BIT_ENCODING_MASK was disabled.
We simply fix this by increasing the expiration time to 2 seconds.
Refer: https://github.com/apache/kvrocks/blob/unstable/src/storage/redis_metadata.cc#L248
This closes #2091