Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default value of parallelism in x.py #1130

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Remove default value of parallelism in x.py #1130

merged 1 commit into from
Nov 22, 2022

Conversation

tisonkun
Copy link
Member

This closes #1125.

@tisonkun
Remove default value of parallelism in x.py
d8d8e20 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun requested a review from PragmaTwice November 21, 2022 10:32
PragmaTwice
PragmaTwice approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@PragmaTwice PragmaTwice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need expose a parameter in dockerfile to specify the concurrent job level. Maybe in another PR.

@tisonkun tisonkun merged commit 074d7ca into apache:unstable Nov 22, 2022
@tisonkun tisonkun deleted the xpy-jobs-no-default branch November 22, 2022 03:41
@tisonkun
Copy link
Member Author

tisonkun commented Nov 22, 2022 •
edited
Loading

@PragmaTwice make sense. Perhaps ARG BUILD_PARALLELISM. You can read https://docs.docker.com/engine/reference/builder/#arg.

@tisonkun tisonkun mentioned this pull request Nov 22, 2022
Closed
@PragmaTwice PragmaTwice mentioned this pull request Feb 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PragmaTwice PragmaTwice PragmaTwice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tisonkun @PragmaTwice