Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nproc instead of default for job numbers in docker build to avoid timeout #1272

Merged
merged 4 commits into from
Feb 21, 2023
Merged

Use nproc instead of default for job numbers in docker build to avoid timeout #1272

merged 4 commits into from
Feb 21, 2023

Conversation

PragmaTwice
Copy link
Member

@PragmaTwice PragmaTwice commented Feb 21, 2023 •
edited
Loading

We use $(nproc) instead of default value for job numbers in docker build to avoid timeout.

Reduce docker build time in kvrocks CI from 39min to 20min.

torwig
torwig approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@torwig torwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

tisonkun
tisonkun approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

... while we already unset the -j arg by default so it's not 4 :)

#1130

@PragmaTwice PragmaTwice changed the title Use nproc instead of 4 for job numbers in docker build to avoid timeout Use nproc instead of default for job numbers in docker build to avoid timeout Feb 21, 2023
@PragmaTwice
Copy link
Member Author

PragmaTwice commented Feb 21, 2023 •
edited
Loading

LGTM

... while we already unset the -j arg by default so it's not 4 :)

#1130

Oh got it, fixed.

@PragmaTwice
Copy link
Member Author

Thanks all. Merging...

@PragmaTwice PragmaTwice merged commit 69a9bda into apache:unstable Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@torwig torwig torwig approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PragmaTwice @git-hulk @torwig @tisonkun