-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the support of the BF.MADD command #1758
Conversation
I add the |
About cc @mapleFU |
Emmm nice catch. Since You can try to use raw-text to check the test reponse in gocase, or cast it to any already-existing pattern( I think it's ok that not fully-consistent with RedisBloom) |
This comment was marked as resolved.
This comment was marked as resolved.
You can maintain a protect/private constructor, and when build from non-owned, you can use a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first glance this looks ok to me, but I think we can add some further optimizations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
src/types/redis_bloom_chain.cc
Outdated
} | ||
|
||
std::string bloom_chain_metadata_bytes; | ||
metadata.Encode(&bloom_chain_metadata_bytes); | ||
batch->Put(metadata_cf_handle_, ns_key, bloom_chain_metadata_bytes); | ||
|
||
batch->Put(bf_key_list.back(), bf_data_list.back()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add a "modified bf indices", rather than this. Assume we trigger "scaling", the logic here would be trickey, because it only put the final bf_data_list
. And when no data has been added, here will also write a batch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, but I wonder would we produce some flacky test if random string is used?
Thanks for your contribution! |
This PR introduce the bloom BF.MADD command.
[1] https://redis.io/commands/bf.madd/