-
Notifications
You must be signed in to change notification settings - Fork 919
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[KYUUBI #4352] Support System.gc() with periodic GC interval
### _Why are the changes needed?_ ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4382 from lightning-L/kyuubi-4352. Closes #4352 2beb1ef [Tianlin Liao] update config name a9eb126 [Tianlin Liao] update config setting 75cdfbb [Tianlin Liao] [KYUUBI #4352] Support System.gc() with periodic GC interval Authored-by: Tianlin Liao <tiliao@ebay.com> Signed-off-by: fwang12 <fwang12@ebay.com>
- Loading branch information
1 parent
ae374c1
commit e5ade90
Showing
4 changed files
with
69 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
kyuubi-server/src/main/scala/org/apache/kyuubi/server/PeriodicGCService.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.kyuubi.server | ||
|
|
||
| import java.util.concurrent.TimeUnit | ||
|
|
||
| import org.apache.kyuubi.config.KyuubiConf | ||
| import org.apache.kyuubi.service.AbstractService | ||
| import org.apache.kyuubi.util.ThreadUtils | ||
|
|
||
| class PeriodicGCService(name: String) extends AbstractService(name) { | ||
| def this() = this(classOf[PeriodicGCService].getSimpleName) | ||
|
|
||
| private val gcTrigger = ThreadUtils.newDaemonSingleThreadScheduledExecutor("periodic-gc-trigger") | ||
|
|
||
| override def start(): Unit = { | ||
| startGcTrigger() | ||
| super.start() | ||
| } | ||
|
|
||
| override def stop(): Unit = { | ||
| super.stop() | ||
| ThreadUtils.shutdown(gcTrigger) | ||
| } | ||
|
|
||
| private def startGcTrigger(): Unit = { | ||
| val interval = conf.get(KyuubiConf.SERVER_PERIODIC_GC_INTERVAL) | ||
| gcTrigger.scheduleWithFixedDelay(() => System.gc(), interval, interval, TimeUnit.MILLISECONDS) | ||
| } | ||
| } |