Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KYUUBI #4352] Support System.gc() with periodic GC interval #4382

Closed
wants to merge 3 commits into from
Closed

[KYUUBI #4352] Support System.gc() with periodic GC interval #4382

wants to merge 3 commits into from

Conversation

lightning-L
Copy link
Contributor

@lightning-L lightning-L commented Feb 20, 2023 •
edited by pan3793
Loading

Why are the changes needed?

Fix #4352

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@github-actions github-actions bot added the kind:documentation Documentation is a feature! label Feb 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2023 •
edited
Loading

Codecov Report

Merging #4382 (a9eb126) into master (0dce65d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head a9eb126 differs from pull request most recent head 59fb890. Consider uploading reports for the commit 59fb890 to get more accurate results

@@             Coverage Diff              @@
##             master    #4382      +/-   ##
============================================
- Coverage     53.72%   53.71%   -0.01%     
  Complexity       13       13              
============================================
  Files           563      564       +1     
  Lines         30877    30892      +15     
  Branches       4164     4164              
============================================
+ Hits          16588    16594       +6     
- Misses        12735    12745      +10     
+ Partials       1554     1553       -1
Impacted Files Coverage Δ
...in/scala/org/apache/kyuubi/config/KyuubiConf.scala 97.45% <100.00%> (+<0.01%) ⬆️
.../scala/org/apache/kyuubi/server/KyuubiServer.scala 53.84% <100.00%> (+1.03%) ⬆️
...a/org/apache/kyuubi/server/PeriodicGCService.scala 100.00% <100.00%> (ø)
.../kyuubi/server/mysql/constant/MySQLErrorCode.scala 13.84% <0.00%> (-6.16%) ⬇️
...ache/kyuubi/server/mysql/MySQLCommandHandler.scala 77.77% <0.00%> (-4.05%) ⬇️
...apache/kyuubi/engine/JpsApplicationOperation.scala 77.41% <0.00%> (-3.23%) ⬇️
...in/spark/authz/ranger/SparkRangerAdminPlugin.scala 64.47% <0.00%> (-2.64%) ⬇️
...ache/kyuubi/server/mysql/MySQLGenericPackets.scala 76.59% <0.00%> (-2.13%) ⬇️
...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala 59.09% <0.00%> (-1.52%) ⬇️
...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala 79.01% <0.00%> (+0.61%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lightning-L
Copy link
Contributor Author

@turboFei

turboFei
turboFei reviewed Feb 20, 2023
View reviewed changes
Copy link
Member

@turboFei turboFei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments，lgtm overall

turboFei
turboFei approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@turboFei turboFei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@turboFei turboFei added this to the v1.7.0 milestone Feb 21, 2023
@turboFei turboFei closed this in e5ade90 Feb 21, 2023
turboFei pushed a commit that referenced this pull request Feb 21, 2023
@lightning-L @turboFei
[KYUUBI #4352] Support System.gc() with periodic GC interval
2db326c 
### _Why are the changes needed?_

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #4382 from lightning-L/kyuubi-4352.

Closes #4352

2beb1ef [Tianlin Liao] update config name
a9eb126 [Tianlin Liao] update config setting
75cdfbb [Tianlin Liao] [KYUUBI #4352] Support System.gc() with periodic GC interval

Authored-by: Tianlin Liao <tiliao@ebay.com>
Signed-off-by: fwang12 <fwang12@ebay.com>
(cherry picked from commit e5ade90)
Signed-off-by: fwang12 <fwang12@ebay.com>
@turboFei
Copy link
Member

thanks, merged to master and branch-1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowenliang123 bowenliang123 bowenliang123 approved these changes

@turboFei turboFei turboFei approved these changes

Assignees

@lightning-L lightning-L

Labels
kind:documentation Documentation is a feature! module:common module:server
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

[Improvement] Support System.gc() with periodic GC interval
4 participants
@lightning-L @codecov-commenter @turboFei @bowenliang123