-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Support engine type and subdomain in kyuubi-ctl #2008
Comments
3 tasks
wForget
pushed a commit
to wForget/kyuubi
that referenced
this issue
Mar 11, 2022
### _Why are the changes needed?_ Introduced engine type and subdomain, kyuubi-ctl does not support managing engine. Add two engine-related parameters(--engine-type --engine-subdomain). apache#2008 ### _How was this patch tested?_ - [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [x] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes apache#2009 from cxzl25/KYUUBI-2008. Closes apache#2008 213a8d9 [sychen] remove println c3895b2 [sychen] fix style fa1e899 [sychen] fix ut 302ae75 [sychen] support engine type and subdomain Authored-by: sychen <sychen@trip.com> Signed-off-by: ulysses-you <ulyssesyou@apache.org>
3 tasks
ulysses-you
pushed a commit
that referenced
this issue
Mar 28, 2022
### _Why are the changes needed?_ #2008 In version 1.5, the kyuubi version is added to the engine path registered to the znode, which makes the original list engine operation invalid. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [x] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #2233 from cxzl25/KYUUBI-2008-FOLLOWUP. Closes #2008 78b8336 [sychen] Engine space with kyuubi version Authored-by: sychen <sychen@trip.com> Signed-off-by: ulysses-you <ulyssesyou@apache.org>
ulysses-you
pushed a commit
that referenced
this issue
Mar 28, 2022
### _Why are the changes needed?_ #2008 In version 1.5, the kyuubi version is added to the engine path registered to the znode, which makes the original list engine operation invalid. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [x] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #2233 from cxzl25/KYUUBI-2008-FOLLOWUP. Closes #2008 78b8336 [sychen] Engine space with kyuubi version Authored-by: sychen <sychen@trip.com> Signed-off-by: ulysses-you <ulyssesyou@apache.org> (cherry picked from commit 015cbe5) Signed-off-by: ulysses-you <ulyssesyou@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Code of Conduct
Search before asking
Describe the feature
Introduced engine type and subdomain, kyuubi-ctl does not support managing engine.
Motivation
Use kyuubi-ctl to manage the engine easily.
Describe the solution
Add two engine-related parameters.
Additional context
No response
Are you willing to submit PR?
The text was updated successfully, but these errors were encountered: