[KYUUBI #2008] Support engine type and subdomain in kyuubi-ctl #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current
Fix
|
hddong
reviewed
Mar 4, 2022
Comment on lines
70
to
74
| // scalastyle:off println | ||
| println(logAppender.loggingEvents) | ||
| println("------") | ||
| println(searchString) | ||
| // scalastyle:on println |
There was a problem hiding this comment.
Shall we remove those debug println?
There was a problem hiding this comment.
Sorry , I added it when I improved ut locally and forgot to remove it.
hddong
approved these changes
Mar 4, 2022
Codecov Report
@@ Coverage Diff @@
## master #2009 +/- ##
============================================
- Coverage 60.57% 60.56% -0.01%
Complexity 69 69
============================================
Files 305 305
Lines 14878 14900 +22
Branches 1925 1927 +2
============================================
+ Hits 9012 9024 +12
- Misses 5096 5105 +9
- Partials 770 771 +1
Continue to review full report at Codecov.
|
SteNicholas
approved these changes
Mar 4, 2022
ulysses-you
approved these changes
Mar 4, 2022
|
thanks, merging to master |
wForget
pushed a commit
to wForget/kyuubi
that referenced
this pull request
Mar 11, 2022
### _Why are the changes needed?_ Introduced engine type and subdomain, kyuubi-ctl does not support managing engine. Add two engine-related parameters(--engine-type --engine-subdomain). apache#2008 ### _How was this patch tested?_ - [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [x] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes apache#2009 from cxzl25/KYUUBI-2008. Closes apache#2008 213a8d9 [sychen] remove println c3895b2 [sychen] fix style fa1e899 [sychen] fix ut 302ae75 [sychen] support engine type and subdomain Authored-by: sychen <sychen@trip.com> Signed-off-by: ulysses-you <ulyssesyou@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Introduced engine type and subdomain, kyuubi-ctl does not support managing engine.
Add two engine-related parameters(--engine-type --engine-subdomain).
#2008
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request