Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Record the client version both for interactive and batch session #4216

Closed
2 of 4 tasks
turboFei opened this issue Jan 31, 2023 · 1 comment
Closed
2 of 4 tasks

[Improvement] Record the client version both for interactive and batch session #4216

turboFei opened this issue Jan 31, 2023 · 1 comment
Assignees
@turboFei

Comments

@turboFei
Copy link
Member

turboFei commented Jan 31, 2023 •
edited
Loading

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

Record the client version both for interactive and batch session.

  • for interactive session
    • transfer the kyuubi-hive-jdbc version when opening connection.
  • for batch session
    • transfer the kyuubi-rest-client version when creating batch request

So that we can check the client version in KyuubiSessionEvent(conf).

If customer call kyuubi service with non-kyuubi-hive-jdbc or native restful way, leave it as empty.

How should we improve?

No response

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
  • No. I cannot submit a PR at this time.
@turboFei
Copy link
Member Author

how do you think about?
cc @pan3793 @lightning-L

@turboFei turboFei mentioned this issue Feb 19, 2023
Closed
3 tasks
@turboFei turboFei self-assigned this Feb 19, 2023
turboFei added a commit that referenced this issue Feb 20, 2023
@turboFei
[KYUUBI #4216] Support to transfer client version for kyuubi hive jdb…
c14e914 
…c and rest client sdk

### _Why are the changes needed?_

To close #4216

### _How was this patch tested?_
- [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #4370 from turboFei/client_version.

Closes #4216

efd934c [fwang12] save
cf8acd5 [fwang12] version properties

Authored-by: fwang12 <fwang12@ebay.com>
Signed-off-by: fwang12 <fwang12@ebay.com>
(cherry picked from commit 3f6ba77)
Signed-off-by: fwang12 <fwang12@ebay.com>
SusurHe pushed a commit to SusurHe/incubator-kyuubi that referenced this issue Feb 21, 2023
Merge branch 'master' of github.com:apache/kyuubi
4cd3d23 
* 'master' of github.com:apache/kyuubi: (1557 commits)
  [KYUUBI apache#3951][FOLLOWUP] Audit the rest request params
  [KYUUBI apache#4377] Grant execute permission to release scripts
  [KYUUBI apache#4374] Release uploading should include kyuubi-spark-connector-hive
  [KYUUBI apache#4267] Show warning if SessionHandle is invalid
  [KYUUBI apache#4385] [DOCS] Refine release process
  [KYUUBI apache#4352] Support System.gc() with periodic GC interval
  [KYUUBI apache#4152][FOLLOWUP] LDAP configurations should be server-only
  [KYUUBI apache#4373] Using SVN_STAGING_REPO instead of SVN_STAGING_REPO in the release script to fix echo message
  [KYUUBI apache#4372] Support to return null value for OperationsResource rowset
  [KYUUBI apache#4371] Fix typo in `kyuubi_ecosystem.drawio`
  [KYUUBI apache#4216] Support to transfer client version for kyuubi hive jdbc and rest client sdk
  [KYUUBI apache#4345] Add the doc of kyuubi trino server
  [KYUUBI apache#3081][DOCS] Add Hudi connector doc in Trino
  [KYUUBI apache#4357] Bump Jersey from 2.38 to 2.39
  [KYUUBI apache#4338][FOLLOWUP] Fix K8s integration tests
  [KYUUBI apache#4326] [ARROW] Fix Spark session timezone format in arrow-based result format
  [KYUUBI apache#4360][FOLLOWUP] Get valid unlimited users from existing limiters instead of conf
  [KYUUBI apache#4362] Add `_configurations` in kerberos.rst
  [KYUUBI apache#4338] Bump Spark from 3.3.1 to 3.3.2
  [KYUUBI apache#4119][FOLLOWUP] Add app start time for batch api docs
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turboFei turboFei

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@turboFei