[KYUUBI #4216] Support to transfer client version for kyuubi hive jdbc and rest client sdk #4370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
changed the title
turboFei
changed the title
turboFei
changed the title
turboFei
force-pushed
the
client_version
branch
2 times, most recently
from
8db8b34 to
2a445f3
Compare
pan3793
reviewed
Feb 19, 2023
|
The ut passed locally, I do not know why it failed on GA, it does not make senses. |
add resources save save save save save save nit nit fix fix and remove unused Revert "fix and remove unused" This reverts commit 15e4465. fix nit
turboFei
force-pushed
the
client_version
branch
from
01c0c4f to
cf8acd5
Compare
|
move the UT to perConnectionSuite. |
turboFei
force-pushed
the
client_version
branch
from
46a5210 to
efd934c
Compare
Codecov Report
@@ Coverage Diff @@
## master #4370 +/- ##
============================================
- Coverage 53.68% 53.67% -0.01%
Complexity 13 13
============================================
Files 562 563 +1
Lines 30834 30863 +29
Branches 4157 4157
============================================
+ Hits 16552 16566 +14
- Misses 12731 12742 +11
- Partials 1551 1555 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pan3793
approved these changes
Feb 20, 2023
|
we can add a udf |
|
thanks, merging to master and 1.7 |
turboFei
added a commit
that referenced
this pull request
Feb 20, 2023
…c and rest client sdk ### _Why are the changes needed?_ To close #4216 ### _How was this patch tested?_ - [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4370 from turboFei/client_version. Closes #4216 efd934c [fwang12] save cf8acd5 [fwang12] version properties Authored-by: fwang12 <fwang12@ebay.com> Signed-off-by: fwang12 <fwang12@ebay.com> (cherry picked from commit 3f6ba77) Signed-off-by: fwang12 <fwang12@ebay.com>
cc @lightning-L |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
To close #4216
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request