Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Propose to use hive-pure-sasl instead of hive_pure_sasl #6445

Closed
3 of 4 tasks
camper42 opened this issue Jun 3, 2024 · 2 comments
Closed
3 of 4 tasks

Comments

@camper42
Copy link
Contributor

camper42 commented Jun 3, 2024

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

We have a python package depends on pyhive[hive_pure_sasl], and we use poetry to manage packaging.

# our package's pyproject.toml
[tool.poetry.dependencies]
PyHive = { extras = ["hive_pure_sasl"], version = "^0.7.0" }

user install our package, get a WARNING: pyhive 0.7.0 does not provide the extra 'hive-pure-sasl' and only installed pyhive without hive_pure_sasl extra, pure-sasl, thrift and thrift_sasl are missing.

after some investigations, I found this python-poetry/poetry#6819.

according to PEP 503 and PEP 685, I think we should use hive-pure-sasl instead of hive_pure_sasl to declear extra requires to avoid this problem.

How should we improve?

change to 'hive-pure-sasl': ['pure-sasl>=0.6.2', 'thrift>=0.10.0', 'thrift_sasl>=0.1.0'],
and release 0.7.1

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
  • No. I cannot submit a PR at this time.
@pan3793
Copy link
Member

pan3793 commented Jun 5, 2024

@camper42 I respect your professionalism in the Python area, please go ahead, and looking forward to your further contributions to the Python module :)

@camper42
Copy link
Contributor Author

camper42 commented Jun 5, 2024

I will verify on our internal pypi that the behavior is as expected first.
happy to contribute to the Python module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants