Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #6445] Normalize extra name for optional Python distribution dependencies #6454

Closed
wants to merge 1 commit into from

Conversation

camper42
Copy link
Contributor

@camper42 camper42 commented Jun 6, 2024

…pendencies

🔍 Description

Issue References 🔗

This pull request fixes #6445

Describe Your Solution 🔧

use hive-pure-sasl instead of hive_pure_sasl for extra name for optional distribution dependencies.

this avoid potential WARNING: pyhive x.y.z does not provide the extra 'hive-pure-sasl' and missing dependencies when a package depends on pyhive[hive_pure_sasl] and python build system choose to normalize it to pyhive[hive-pure-saal].

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

a package depends on pyhive[hive_pure_sasl] may complain WARNING: pyhive x.y.z does not provide the extra 'hive-pure-sasl' and missing dependencies to support hive feature.

Behavior With This Pull Request 🎉

based on my test on our internal pypi, users use pyhive[hive_pure_sasl] are not affected by this change. But we should update README when we release a new version of pyhive.

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.44%. Comparing base (ef203e0) to head (d82e5ca).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6454      +/-   ##
============================================
- Coverage     58.46%   58.44%   -0.02%     
  Complexity       24       24              
============================================
  Files           656      656              
  Lines         40267    40267              
  Branches       5498     5498              
============================================
- Hits          23544    23536       -8     
- Misses        14219    14227       +8     
  Partials       2504     2504              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@camper42
Copy link
Contributor Author

camper42 commented Jun 6, 2024

A quick look at #6341 shows that it changes hive_pure_sasl to hive-pure-sasl as well, but there's no record of why this was done. I think it's good to keep a seperate PR

@pan3793 pan3793 changed the title [KYUUBI #6445] use normalized extra name for optional distribution de… [KYUUBI #6445] Normalize extra name for optional Python distribution dependencies Jun 6, 2024
@pan3793 pan3793 added this to the v1.10.0 milestone Jun 6, 2024
@pan3793 pan3793 closed this in 96d8b8e Jun 6, 2024
@pan3793
Copy link
Member

pan3793 commented Jun 6, 2024

Thanks, merged to master

@camper42 camper42 deleted the python branch June 6, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Propose to use hive-pure-sasl instead of hive_pure_sasl
3 participants