[KYUUBI #6445] Normalize extra name for optional Python distribution dependencies #6454
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pendencies
🔍 Description
Issue References 🔗
This pull request fixes #6445
Describe Your Solution 🔧
use
hive-pure-sasl
instead ofhive_pure_sasl
for extra name for optional distribution dependencies.this avoid potential
WARNING: pyhive x.y.z does not provide the extra 'hive-pure-sasl'
and missing dependencies when a package depends onpyhive[hive_pure_sasl]
and python build system choose to normalize it topyhive[hive-pure-saal]
.Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
a package depends on
pyhive[hive_pure_sasl]
may complainWARNING: pyhive x.y.z does not provide the extra 'hive-pure-sasl'
and missing dependencies to support hive feature.Behavior With This Pull Request 🎉
based on my test on our internal pypi, users use
pyhive[hive_pure_sasl]
are not affected by this change. But we should update README when we release a new version of pyhive.Related Unit Tests
Checklist 📝
Be nice. Be informative.