-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KYUUBI #6281][PY] Add lint rules and action lint checks #6341
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6341 +/- ##
============================================
- Coverage 58.49% 58.48% -0.02%
Complexity 24 24
============================================
Files 653 653
Lines 39974 39974
Branches 5489 5489
============================================
- Hits 23384 23379 -5
- Misses 14080 14091 +11
+ Partials 2510 2504 -6 ☔ View full report in Codecov by Sentry. |
I'm not sure we should apply new code-style rules at the current stage, I think we should postpone such things at least until the first release is completed. The most urgent thing is setting up CI to run the python test to ensure our ongoing changes won't break the code. |
sure we can get back to this PR later however, I'm facing an authentication error installing CDH and trying docker-compose as another approach |
we can use the Apache version for testing. this project may help you to choose the version combination |
a1e772a
to
98c3192
Compare
@pan3793 think we can resume this PR 😄 |
Signed-off-by: Harry <quanghai.ng1512@gmail.com>
Signed-off-by: Harry <quanghai.ng1512@gmail.com>
Signed-off-by: Harry <quanghai.ng1512@gmail.com>
🔍 Description
Issue References 🔗
This pull request fixes #6281
Describe Your Solution 🔧
As part of our efforts to introduce python client built on top of Dropbox's PyHive, I've initialized some linting rules to check with github actions.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Code was following flake8 default format which is not sufficient
Behavior With This Pull Request 🎉
Lint checks now are powered by ruff
Checklist 📝
Be nice. Be informative.