-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KYUUBI #1262] Support both KERBEROS and PLAIN authentication at the same time #1266
Conversation
eeef9b5
to
ac8b195
Compare
ff6bfd9
to
c00e054
Compare
c00e054
to
1aa30a5
Compare
#642 introduces a |
72e55d6
to
8545a03
Compare
Codecov Report
@@ Coverage Diff @@
## master #1266 +/- ##
============================================
+ Coverage 73.10% 78.30% +5.19%
- Complexity 41 110 +69
============================================
Files 175 177 +2
Lines 6846 7103 +257
Branches 835 872 +37
============================================
+ Hits 5005 5562 +557
+ Misses 1441 1061 -380
- Partials 400 480 +80
Continue to review full report at Codecov.
|
294c43f
to
8dadfd3
Compare
e37cc09
to
1945c34
Compare
1945c34
to
4fc6308
Compare
it is ready now. cc @pan3793 |
kyuubi-common/src/test/scala/org/apache/kyuubi/operation/JDBCTestUtils.scala
Outdated
Show resolved
Hide resolved
Thanks, merging to master |
… on macOS ### _Why are the changes needed?_ 1. transfer KRB5_CONF of KyuubiServer to kinit process in case the system KRB5_CONF is not same with `java.security.krb5.conf` of KyuubiServer JVM. 2. The UT with kerberos enabled KyuubiServer can not pass on osx environment, such as `KyuubiOperationKerberosAndPlainAuthSuite` (#1266). For the root cause, see details in https://stackoverflow.com/questions/27053539/openldap-kerberos-unable-to-reach-any-kdc-in-realm ### _How was this patch tested?_ `KyuubiOperationKerberosAndPlainAuthSuite` can pass on my MacBook, without this PR, it will fail on MacBook. Closes #1291 from turboFei/kinit_ut. Closes #1291 f006054 [fwang12] complete KRB5_CONFIG 859538c [fwang12] Make kerberos enabled kyuubi server unit test runnable for osx environment Authored-by: fwang12 <fwang12@ebay.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
Why are the changes needed?
Support both KERBEROS and PLAIN authentication at the same time.
How was this patch tested?
Added UT & IT.
I make integration testing on our dev cluster with KERBEROS and CUSTOM authentication.
For org.apache.kyuubi.ZeusCustom, it checks whether the user equals password.
kerberos testing with user b_zeus
CUTOM authentication testing with user b_zeus
Note that: they share the same backend spark engine, because they are the same user.