[TEST] Transfer KRB5_CONF to kinit and fix kerberos UT on macOS #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
changed the title
pan3793
reviewed
Oct 25, 2021
kyuubi-common/src/test/scala/org/apache/kyuubi/KerberizedTestHelper.scala
Show resolved
Hide resolved
turboFei
changed the title
turboFei
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1291 +/- ##
=========================================
Coverage 78.27% 78.27%
Complexity 110 110
=========================================
Files 177 177
Lines 7103 7108 +5
Branches 874 874
=========================================
+ Hits 5560 5564 +4
- Misses 1063 1064 +1
Partials 480 480
Continue to review full report at Codecov.
|
zjffdu
reviewed
Oct 25, 2021
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KinitAuxiliaryService.scala
Outdated
Show resolved
Hide resolved
turboFei
commented
Oct 25, 2021
| @@ -45,7 +45,8 @@ class KinitAuxiliaryService() extends AbstractService("KinitAuxiliaryService") { | |||
|
|
|||
| require(keytab.nonEmpty && principal.nonEmpty, "principal or keytab is missing") | |||
| UserGroupInformation.loginUserFromKeytab(principal.get, keytab.get) | |||
| val commands = Seq("kinit", "-kt", keytab.get, principal.get) | |||
| val krb5Conf = System.getProperty("java.security.krb5.conf") | |||
| val commands = Seq(s"env KRB5_CONFIG=$krb5Conf", "kinit", "-kt", keytab.get, principal.get) | |||
There was a problem hiding this comment.
for the commands executed in processBuilder, its default KRB5_CONFIG is not same with the value of java.security.krb5.conf of KyuubiServer JVM.
turboFei
changed the title
turboFei
changed the title
pan3793
changed the title
pan3793
approved these changes
Oct 25, 2021
|
Thanks, merging to master |
yaooqinn
reviewed
Oct 26, 2021
| @@ -45,8 +45,12 @@ class KinitAuxiliaryService() extends AbstractService("KinitAuxiliaryService") { | |||
|
|
|||
| require(keytab.nonEmpty && principal.nonEmpty, "principal or keytab is missing") | |||
| UserGroupInformation.loginUserFromKeytab(principal.get, keytab.get) | |||
| val krb5Conf = Option(System.getProperty("java.security.krb5.conf")) | |||
There was a problem hiding this comment.
Shall we get it from KyuubiConf？
yaooqinn
reviewed
Oct 26, 2021
| @@ -45,8 +45,12 @@ class KinitAuxiliaryService() extends AbstractService("KinitAuxiliaryService") { | |||
|
|
|||
| require(keytab.nonEmpty && principal.nonEmpty, "principal or keytab is missing") | |||
| UserGroupInformation.loginUserFromKeytab(principal.get, keytab.get) | |||
| val krb5Conf = Option(System.getProperty("java.security.krb5.conf")) | |||
| .orElse(Option(System.getenv("KRB5_CONFIG"))) | |||
There was a problem hiding this comment.
Shall we add KRB5_CONFIG to kyuubi-env.sh.template?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
java.security.krb5.confof KyuubiServer JVM.KyuubiOperationKerberosAndPlainAuthSuite([KYUUBI #1262] Support both KERBEROS and PLAIN authentication at the same time #1266). For the root cause, see details in https://stackoverflow.com/questions/27053539/openldap-kerberos-unable-to-reach-any-kdc-in-realmHow was this patch tested?
KyuubiOperationKerberosAndPlainAuthSuitecan pass on my MacBook, without this PR, it will fail on MacBook.