[KYUUBI #4305][Bug] Backport HIVE-15820: comment at the head of beeline -e #4333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add some unit tests for testing single comment line and multi single-line comments ? |
Codecov Report
@@ Coverage Diff @@
## master #4333 +/- ##
============================================
+ Coverage 53.40% 53.53% +0.12%
Complexity 13 13
============================================
Files 560 562 +2
Lines 30569 30713 +144
Branches 4139 4143 +4
============================================
+ Hits 16326 16441 +115
- Misses 12706 12726 +20
- Partials 1537 1546 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
How about ut for multi single-line comments (also with some space in front)? |
bowenliang123
approved these changes
Feb 15, 2023
|
Run |
|
@cfmcgrady would you please check will this change breaks the pyspark case? |
I think this should be a breaking change to run python snippets. I will check when I have time. |
|
test run multi-line python snippets with this change. |
cfmcgrady
approved these changes
Feb 16, 2023
|
thanks, merging to master(v1.8.0)/branch-1.7(v1.7.0)/branch-1.6(v1.6.2) |
cfmcgrady
pushed a commit
that referenced
this pull request
Feb 16, 2023
…ne -e ### _Why are the changes needed?_ close [#4305](#4305) ### manual tests ```sql bin/beeline -u jdbc:hive2://X:10009 -e " --asd select 1 as a " ```  ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [x] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4333 from lsm1/fix/beeline_comment_header. Closes #4305 f932d4e [senmiaoliu] reformat 9a071fb [senmiaoliu] added multi line ut 425c536 [senmiaoliu] added ut d4dc21a [senmiaoliu] comment at the head of beeline -e Authored-by: senmiaoliu <senmiaoliu@trip.com> Signed-off-by: Fu Chen <cfmcgrady@gmail.com> (cherry picked from commit c489e29) Signed-off-by: Fu Chen <cfmcgrady@gmail.com>
cfmcgrady
pushed a commit
that referenced
this pull request
Feb 16, 2023
…ne -e close [#4305](#4305) ```sql bin/beeline -u jdbc:hive2://X:10009 -e " --asd select 1 as a " ```  - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [x] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4333 from lsm1/fix/beeline_comment_header. Closes #4305 f932d4e [senmiaoliu] reformat 9a071fb [senmiaoliu] added multi line ut 425c536 [senmiaoliu] added ut d4dc21a [senmiaoliu] comment at the head of beeline -e Authored-by: senmiaoliu <senmiaoliu@trip.com> Signed-off-by: Fu Chen <cfmcgrady@gmail.com> (cherry picked from commit c489e29) Signed-off-by: Fu Chen <cfmcgrady@gmail.com>
|
sorry for wrongly locally testing before, this is a breaking change for submitting multi-line python snippets. log |
|
@cfmcgrady, any solution? we should revert it if we can not fix it properly |
I don't have any thoughts on this issue, maybe we should revert it first? |
3 tasks
We can add this python UT later? |
pan3793
pushed a commit
that referenced
this pull request
Feb 24, 2023
…nt at the head … …of beeline -e" This reverts commit c489e29. ### _Why are the changes needed?_ #4333 (comment) ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4406 from cfmcgrady/revert-4333. Closes #4406 Closes #4305 c7fff72 [Fu Chen] Revert "[KYUUBI #4305][Bug] Backport HIVE-15820: comment at the head of beeline -e" Authored-by: Fu Chen <cfmcgrady@gmail.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
pan3793
pushed a commit
that referenced
this pull request
Feb 24, 2023
…nt at the head … …of beeline -e" This reverts commit c489e29. ### _Why are the changes needed?_ #4333 (comment) ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4406 from cfmcgrady/revert-4333. Closes #4406 Closes #4305 c7fff72 [Fu Chen] Revert "[KYUUBI #4305][Bug] Backport HIVE-15820: comment at the head of beeline -e" Authored-by: Fu Chen <cfmcgrady@gmail.com> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit b39caed) Signed-off-by: Cheng Pan <chengpan@apache.org>
3 tasks
cfmcgrady
added a commit
that referenced
this pull request
Mar 22, 2023
### _Why are the changes needed?_ to resolve #4333 (comment) ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4581 from cfmcgrady/beeline-parser-python-ut. Closes #4581 9bffa03 [Fu Chen] add KyuubiCommands parse python snippets unit test Authored-by: Fu Chen <cfmcgrady@gmail.com> Signed-off-by: Fu Chen <cfmcgrady@gmail.com>
cfmcgrady
added a commit
that referenced
this pull request
Mar 22, 2023
to resolve #4333 (comment) - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4581 from cfmcgrady/beeline-parser-python-ut. Closes #4581 9bffa03 [Fu Chen] add KyuubiCommands parse python snippets unit test Authored-by: Fu Chen <cfmcgrady@gmail.com> Signed-off-by: Fu Chen <cfmcgrady@gmail.com> (cherry picked from commit acdfa6c) Signed-off-by: Fu Chen <cfmcgrady@gmail.com>
Kiss736921
pushed a commit
to Kiss736921/kyuubi
that referenced
this pull request
Mar 23, 2023
…unit test ### _Why are the changes needed?_ to resolve apache#4333 (comment) ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes apache#4581 from cfmcgrady/beeline-parser-python-ut. Closes apache#4581 9bffa03 [Fu Chen] add KyuubiCommands parse python snippets unit test Authored-by: Fu Chen <cfmcgrady@gmail.com> Signed-off-by: Fu Chen <cfmcgrady@gmail.com>
3 tasks
turboFei
added a commit
that referenced
this pull request
Jun 16, 2023
…ne -e ### _Why are the changes needed?_ Backport apache/hive#1814 related kyuubi issues #4305 #4333 #4406 ### _How was this patch tested?_ - [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4972 from turboFei/beeline_head_command. Closes #4305 04b235f [fwang12] [KYUUBI #4305][Bug] Backport HIVE-15820: comment at the head of beeline -e Authored-by: fwang12 <fwang12@ebay.com> Signed-off-by: fwang12 <fwang12@ebay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
close #4305
manual tests
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request