Revert "[KYUUBI #4305][Bug] Backport HIVE-15820: comment at the head … #4406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… head of beeline -e" This reverts commit c489e29.
pan3793
approved these changes
Feb 24, 2023
cxzl25
approved these changes
Feb 24, 2023
Codecov Report
@@ Coverage Diff @@
## master #4406 +/- ##
============================================
- Coverage 53.81% 53.76% -0.05%
Complexity 13 13
============================================
Files 564 564
Lines 30929 30927 -2
Branches 4163 4163
============================================
- Hits 16643 16629 -14
- Misses 12735 12744 +9
- Partials 1551 1554 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pan3793
pushed a commit
that referenced
this pull request
Feb 24, 2023
…nt at the head … …of beeline -e" This reverts commit c489e29. ### _Why are the changes needed?_ #4333 (comment) ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4406 from cfmcgrady/revert-4333. Closes #4406 Closes #4305 c7fff72 [Fu Chen] Revert "[KYUUBI #4305][Bug] Backport HIVE-15820: comment at the head of beeline -e" Authored-by: Fu Chen <cfmcgrady@gmail.com> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit b39caed) Signed-off-by: Cheng Pan <chengpan@apache.org>
|
Thanks, merged to master/1.7 |
3 tasks
turboFei
added a commit
that referenced
this pull request
Jun 16, 2023
…ne -e ### _Why are the changes needed?_ Backport apache/hive#1814 related kyuubi issues #4305 #4333 #4406 ### _How was this patch tested?_ - [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4972 from turboFei/beeline_head_command. Closes #4305 04b235f [fwang12] [KYUUBI #4305][Bug] Backport HIVE-15820: comment at the head of beeline -e Authored-by: fwang12 <fwang12@ebay.com> Signed-off-by: fwang12 <fwang12@ebay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…of beeline -e"
This reverts commit c489e29.
Why are the changes needed?
#4333 (comment)
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request