Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spark-sql-engine's classes should not be visible in server module #6708

Closed
wants to merge 3 commits into from
Closed

spark-sql-engine's classes should not be visible in server module #6708

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c58d2d
IDEA-93855
pan3793 Sep 18, 2024
e4a8d36
nit
pan3793 Sep 22, 2024
a73fd42
fix
pan3793 Sep 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions kyuubi-server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,10 +276,21 @@
<scope>test</scope>
</dependency>

<!--
The server module does not consume the `spark-sql-engine` classes, but it supposes that
`spark-sql-engine`'s jar existed on the target folder, so here we declare it as a dependency
to make sure that Maven always processes `spark-sql-engine` module before the server module.
IntelliJ IDEA 2024.1 fixed the IDEA-93855, thus the relocated classes inside the
`spark-sql-engine`'s shaded jar are visible in the server module in IDEA, for example,
`org.apache.kyuubi.shaded.spark.connect.proto.ExecutePlanRequest`, which silently breaks
the IDEA code analysis and jumping capabilities. It seems to be a workaround by changing
the dependency type from `jar`(default value) to `pom`.
-->
<dependency>
<groupId>org.apache.kyuubi</groupId>
<artifactId>kyuubi-spark-sql-engine_${scala.binary.version}</artifactId>
<version>${project.version}</version>
<type>pom</type>
<scope>test</scope>
</dependency>

Expand Down
Loading