spark-sql-engine's classes should not be visible in server module #6708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6708 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 684 684
Lines 42279 42279
Branches 5765 5765
======================================
Misses 42279 42279
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cxzl25
approved these changes
Sep 23, 2024
pan3793
added a commit
that referenced
this pull request
Sep 23, 2024
…rver module # 🔍 Description ## Issue References 🔗 The server module does not consume the `spark-sql-engine` classes, but it supposes that `spark-sql-engine`'s jar existed on the target folder, so here we declare it as a dependency to make sure that Maven always processes `spark-sql-engine` module before the server module. IntelliJ IDEA 2024.1 fixed the IDEA-93855, thus the relocated classes inside the `spark-sql-engine`'s shaded jar are visible in the server module in IDEA, for example, `org.apache.kyuubi.shaded.spark.connect.proto.ExecutePlanRequest`, which silently breaks the IDEA code analysis and jumping capabilities. ## Describe Your Solution 🔧 Changing the dependency type from `jar`(default value) to `pom` seems to be a workaround. ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 <img width="593" alt="image" src="https://github.com/user-attachments/assets/cc53709a-5f9d-4452-a24f-0c84e2342191"> #### Behavior Without This Pull Request ⚰️ <img width="1511" alt="image" src="https://github.com/user-attachments/assets/1c547c6d-a603-4c9d-92b4-8e2059b35fac"> #### Behavior With This Pull Request 🎉 <img width="1509" alt="image" src="https://github.com/user-attachments/assets/55f9e6e5-b9ea-4959-9142-ab7db21ab9b1"> --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6708 from pan3793/IDEA-93855. Closes #6708 a73fd42 [Cheng Pan] fix e4a8d36 [Cheng Pan] nit 8c58d2d [Cheng Pan] IDEA-93855 Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit 1d35cf2) Signed-off-by: Cheng Pan <chengpan@apache.org>
pan3793
added a commit
that referenced
this pull request
Sep 23, 2024
…rver module # 🔍 Description ## Issue References 🔗 The server module does not consume the `spark-sql-engine` classes, but it supposes that `spark-sql-engine`'s jar existed on the target folder, so here we declare it as a dependency to make sure that Maven always processes `spark-sql-engine` module before the server module. IntelliJ IDEA 2024.1 fixed the IDEA-93855, thus the relocated classes inside the `spark-sql-engine`'s shaded jar are visible in the server module in IDEA, for example, `org.apache.kyuubi.shaded.spark.connect.proto.ExecutePlanRequest`, which silently breaks the IDEA code analysis and jumping capabilities. ## Describe Your Solution 🔧 Changing the dependency type from `jar`(default value) to `pom` seems to be a workaround. ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 <img width="593" alt="image" src="https://github.com/user-attachments/assets/cc53709a-5f9d-4452-a24f-0c84e2342191"> #### Behavior Without This Pull Request ⚰️ <img width="1511" alt="image" src="https://github.com/user-attachments/assets/1c547c6d-a603-4c9d-92b4-8e2059b35fac"> #### Behavior With This Pull Request 🎉 <img width="1509" alt="image" src="https://github.com/user-attachments/assets/55f9e6e5-b9ea-4959-9142-ab7db21ab9b1"> --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6708 from pan3793/IDEA-93855. Closes #6708 a73fd42 [Cheng Pan] fix e4a8d36 [Cheng Pan] nit 8c58d2d [Cheng Pan] IDEA-93855 Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit 1d35cf2) Signed-off-by: Cheng Pan <chengpan@apache.org>
|
Thanks, merged to master/1.9.3/1.8.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
The server module does not consume the
spark-sql-engineclasses, but it supposes thatspark-sql-engine's jar existed on the target folder, so here we declare it as a dependencyto make sure that Maven always processes
spark-sql-enginemodule before the server module.IntelliJ IDEA 2024.1 fixed the IDEA-93855, thus the relocated classes inside the
spark-sql-engine's shaded jar are visible in the server module in IDEA, for example,org.apache.kyuubi.shaded.spark.connect.proto.ExecutePlanRequest, which silently breaksthe IDEA code analysis and jumping capabilities.
Describe Your Solution 🔧
Changing the dependency type from
jar(default value) topomseems to be a workaround.Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Checklist 📝
Be nice. Be informative.