Skip to content

Conversation

jluehe
Copy link
Contributor

@jluehe jluehe commented May 25, 2025

… directly instead of reflectively (#3686)

This pull request fixes issue #3686 by having org.apache.logging.log4j.util.Base64Util invoke java.util.Base64 directly instead of reflectively. This avoids the need to use javax.xml.bind.DataTypeConverter as a fallback, which has been problematic because it is not Jakarta EE9 compliant.

Checklist

  • Base your changes on 2.x branch if you are targeting Log4j 2; use main otherwise
  • ./mvnw verify succeeds (if it fails due to code formatting issues reported by Spotless, simply run ./mvnw spotless:apply and retry)
  • Non-trivial changes contain an entry file in the src/changelog/.2.x.x directory
  • Tests for the changes are provided
  • Commits are signed (optional, but highly recommended)

Copy link
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppkarwasz ppkarwasz enabled auto-merge (squash) May 25, 2025 07:59
@ppkarwasz
Copy link
Contributor

@jluehe,

Thanks! This pull request will be merged as soon as the required checks pass.

auto-merge was automatically disabled May 25, 2025 08:04

Head branch was pushed to by a user without write access

Copy link

Job Requested goals Build Tool Version Build Outcome Build Scan®
build-macos-latest clean install 3.9.8 Build Scan PUBLISHED
build-ubuntu-latest clean install 3.9.8 Build Scan PUBLISHED
build-windows-latest clean install 3.9.8 Build Scan PUBLISHED
Generated by gradle/develocity-actions

@jluehe
Copy link
Contributor Author

jluehe commented May 25, 2025

@ppkarwasz, I'm afraid that by squashing my commits, the signature disappeared ... Should I create a new PR?

@jluehe
Copy link
Contributor Author

jluehe commented May 25, 2025

@ppkarwasz, I'm afraid that by squashing my commits, the signature disappeared ... Should I create a new PR?

@ppkarwasz, recreated the PR at #3690, confirming it is properly signed. Closing this PR

@jluehe jluehe closed this May 25, 2025
@github-project-automation github-project-automation bot moved this from To triage to Done in Log4j bug tracker May 25, 2025
@ppkarwasz
Copy link
Contributor

I'm afraid that by squashing my commits, the signature disappeared ... Should I create a new PR?

In general we prefer to use the same PR. Missing signatures can be corrected via a forced push that replaces all the commits:

git rebase --force-rebase --gpg-sign origin/2.x
git push --force

@jluehe
Copy link
Contributor Author

jluehe commented May 25, 2025

I'm afraid that by squashing my commits, the signature disappeared ... Should I create a new PR?

In general we prefer to use the same PR. Missing signatures can be corrected via a forced push that replaces all the commits:

git rebase --force-rebase --gpg-sign origin/2.x
git push --force

Thanks, @ppkarwasz - that's good to know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants