Fix Flaky Test In TestBlockJoinBulkScorer (#13785)

lucene/join/src/test/org/apache/lucene/search/join/TestBlockJoinBulkScorer.java

@@ -27,6 +27,7 @@
 import java.util.HashSet;
 import java.util.List;
 import java.util.Map;
+import java.util.Objects;
 import java.util.Set;
 import java.util.stream.Collectors;
 import org.apache.lucene.document.Document;
@@ -275,6 +276,15 @@ private static void assertScores(
  Float minScore,
  Map<Integer, Float> expectedScores)
  throws IOException {
+ assertScores(bulkScorer, scoreMode, minScore, List.of(expectedScores));
+ }
+
+ private static void assertScores(
+ BulkScorer bulkScorer,
+ org.apache.lucene.search.ScoreMode scoreMode,
+ Float minScore,
+ List<Map<Integer, Float>> expectedScoresList)
+ throws IOException {
  Map<Integer, Float> actualScores = new HashMap<>();
  bulkScorer.score(
  new LeafCollector() {
@@ -298,7 +308,26 @@ public void collect(int doc) throws IOException {
  null,
  0,
  NO_MORE_DOCS);
- assertEquals(expectedScores, actualScores);
+
+ if (expectedScoresList.size() == 1) {
+ assertEquals(expectedScoresList.get(0), actualScores);
+ } else {
+ assertEqualsToOneOf(expectedScoresList, actualScores);
+ }
+ }
+
+ private static void assertEqualsToOneOf(List<?> expectedList, Object actual) {
+ boolean foundMatch = false;
+ for (Object expected : expectedList) {
+ if (Objects.equals(expected, actual)) {
+ foundMatch = true;
+ break;
+ }
+ }
+
+ if (!foundMatch) {
+ throw new AssertionError("expected one of: " + expectedList + " but was: " + actual);
+ }
  }
 
  public void testScoreRandomIndices() throws IOException {
@@ -384,17 +413,25 @@ public void testSetMinCompetitiveScoreWithScoreModeMax() throws IOException {
  }
 
  {
- // Doc 16 is returned because MaxScoreBulkScorer scores assuming A will match in doc 13,
- // leading to a potential max score of 6. By the time it determines that A doesn't match,
- // scoring is complete and thus there is no advantage to not collecting the doc.
- Map<Integer, Float> expectedScores =
+ // This test case has two potential results.
+ // If all docs are scored in the same batch, then doc 16 is collected because
+ // MaxScoreBulkScorer scores assuming A will match in doc 13, leading to a potential max
+ // score of 6.
+ // If the scoring is split across two or more batches, then doc 16 is not collected
+ // because MaxScoreBulkScorer does not assume A will match in doc 13, leading to a
+ // potential max score of 5.
+ Map<Integer, Float> expectedScores1 =
+ Map.of(
+ 2, 6.0f,
+ 10, 10.0f);
+ Map<Integer, Float> expectedScores2 =
  Map.of(
  2, 6.0f,
  10, 10.0f,
  16, 5.0f);
 
  BulkScorer bulkScorer = weight.bulkScorer(searcher.getIndexReader().leaves().get(0));
- assertScores(bulkScorer, scoreMode, 6.0f, expectedScores);
+ assertScores(bulkScorer, scoreMode, 6.0f, List.of(expectedScores1, expectedScores2));
  }
 
  {