Add support for reloading the SPI for KnnVectorsFormat class #13394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Navneet Verma <navneev@amazon.com>
|
cc: @benwtrent , @msokolov |
jmazanec15
approved these changes
May 21, 2024
|
@uschindler @ChrisHegarty, @mikemccand Could you please take a look, if you get a chance? |
uschindler
approved these changes
May 27, 2024
|
@ChrisHegarty , @uschindler can you merge the code and add the backport label to backport the code to branch_9x |
asfgit
pushed a commit
that referenced
this pull request
May 27, 2024
Signed-off-by: Navneet Verma <navneev@amazon.com>
|
Done! Thanks, @navneet1v |
|
@uschindler do i need to create a separate PR for porting this change to branch_9x or there is any automated way to do this? |
|
thats already merged (see above @ "asfgit pushed...."). |
|
@uschindler thanks. I didn't realize it. Generally I see labels added or last time I raised the PR manually for backport. Thanks for confirming this code is merged. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for reloading the SPI for KnnVectorsFormat class
Ref: #13393
I would also like to backport it to 9.x branch of Lucene