Enabled reloading functionality for reloading KNNVectorsFormat SPIs from plugins

[navneet1v]

Description

Enabled reloading functionality for reloading KNNVectorsFormat SPIs from plugins.

This change will ensure that if plugins are overriding the KNNVectorsFormat class of Lucene, Lucene KNNVectorsFormat SPI is able to use them while creating KNNVectorsFormat classes using SPI interfaces.

This feature is currently available in Lucene 9.11 version(branch_9x) hence we will not be backporting this change to 2.x. Once we upgrade 2.x branch to 9.11 version of Lucene this change needs to be backported to 2.x

Lucene upgrade PR: #13850

Lucene change : apache/lucene#13394

Related Issues

NA

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• API changes companion pull request created.
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[navneet1v]

cc : @reta , @msfroh. Very small PR. :D

[github-actions]

❕ Gradle check result for f2d979a: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.59%. Comparing base (b15cb0c) to head (f2d979a).
Report is 315 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #13864      +/-   ##
============================================
+ Coverage     71.42%   71.59%   +0.16%     
- Complexity    59978    61278    +1300     
============================================
  Files          4985     5063      +78     
  Lines        282275   288031    +5756     
  Branches      40946    41710     +764     
============================================
+ Hits         201603   206202    +4599     
- Misses        63999    64826     +827     
- Partials      16673    17003     +330     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[navneet1v]

Not sure why grable assemble on macos-13 fails. Is this expected?

[reta]

Not sure why grable assemble on macos-13 fails. Is this expected?

The MacOS-13 / colima (Docker) is super unstable after GA switched to new MacOS runners :(

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13864-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 05fb780a3aec3bfb46c0cb76c65e340b11d42def
# Push it to GitHub
git push --set-upstream origin backport/backport-13864-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-13864-to-2.x.

[reta]

Backport is not needed: the change was picked in #14074

[navneet1v]

Backport is not needed: the change was picked in #14074

Thanks @reta I was not aware of it. So thought I should start first by doing a backport. I will remove the backport tag.