Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PayloadScoreQuery javadoc update w.r.t. SpanQuery use #13731

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

cpoerschke
Copy link
Contributor

No description provided.

/** A Query class that uses a {@link PayloadFunction} to modify the score of a wrapped SpanQuery */
/**
* A Query class that uses a {@link PayloadFunction} to modify the score of a wrapped {@link SpanQuery}.
* A wrapped span query is used due to the way that payload values are indexed, see {@link PostingsEnum#PAYLOADS}.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence aims to answer any "why does it have to be a span (query)?" question, the wording is perhaps a bit awkward, edits or suggestions for alternatives welcome. Thanks!

@cpoerschke cpoerschke marked this pull request as ready for review September 6, 2024 09:52
Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@cpoerschke cpoerschke merged commit ef577ea into apache:main Sep 12, 2024
3 checks passed
@cpoerschke cpoerschke deleted the psp-docs branch September 12, 2024 10:23
asfgit pushed a commit that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants