Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payload Score Parser: expand documentation's pointing to Lucene javadocs #2693

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cpoerschke
Copy link
Contributor

see also apache/lucene#13731 PayloadScoreQuery javadoc update w.r.t. SpanQuery use

@github-actions github-actions bot added documentation Improvements or additions to documentation cat:search labels Sep 6, 2024
Comment on lines -954 to -955
`PayloadScoreQParser` incorporates each matching term's numeric (integer or float) payloads into the scores.
The main query is parsed from the field type's query analysis into a `SpanQuery` based on the value of the `operator` parameter below.
Copy link
Contributor Author

@cpoerschke cpoerschke Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpoerschke cpoerschke marked this pull request as ready for review September 6, 2024 10:31
@epugh
Copy link
Contributor

epugh commented Sep 12, 2024

How do I compile the javadocs? I normally run gw buildLocalSite but that doesn't get the docs! Can't find a mention in :helpWorkflow either!

@cpoerschke
Copy link
Contributor Author

How do I compile the javadocs? I normally run gw buildLocalSite but that doesn't get the docs! Can't find a mention in :helpWorkflow either!

Thanks for taking a look! Interesting. I tend to use ./gradlew javadoc but don't recall how found that, maybe experimentation. Would be good to have it more discoverable, for sure.

As an aside, it seems the Solr javadocs don't link across to the Lucene javadocs -- would be nice if they did, no idea what it would take to do so. Sample link: https://solr.apache.org/docs/9_7_0/core/org/apache/solr/search/SolrIndexSearcher.html

Copy link

This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the dev@solr.apache.org mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution!

@github-actions github-actions bot added the stale PR not updated in 60 days label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:search documentation Improvements or additions to documentation stale PR not updated in 60 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants