Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSHARED-870] - Upgrade asm to 8.0.1 #11

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

adangel
Copy link
Member

@adangel adangel commented Jul 2, 2020

Upgrades again from 8.0.0 -> 8.0.1
Also uses the new Opcodes constant, so that the new features can actually be used.

Note: we could go to ASM9_EXPERIMENTAL to support class files with preview features as well.

Note2: I'm reusing MSHARED-870, since maven-dependency-analyzer 1.1.2 is not released yet. I'll reopen that issue.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes. Also be sure having selected the correct component.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MSHARED-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MSHARED-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@slachiewicz slachiewicz merged commit 16e0f4e into apache:master Jul 2, 2020
@slachiewicz
Copy link
Member

There are few more references to Opcode.ASM7 - should we also update them ?

@adangel
Copy link
Member Author

adangel commented Jul 3, 2020

Probably yes, I'll update the other references. It worked for me without these, but it of course depends on the class files/features, that are analyzed.

@adangel
Copy link
Member Author

adangel commented Jul 3, 2020

Done in e867083

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants