Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update maven-dependency-analyzer #1537

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Update maven-dependency-analyzer #1537

merged 1 commit into from
Nov 10, 2020

Conversation

fawind
Copy link
Contributor

@fawind fawind commented Nov 10, 2020

Before this PR

checkUnusedDependencies errors when the code contains new preview features. This is because the current version of maven-dependency-analyzer does not use the new ASM8 features.

> checkUnusedDependenciesMain
java.lang.UnsupportedOperationException: This feature requires ASM8

After this PR

Update maven-dependency-analyzer to 1.11.3 to pick up the update to ASM 8 (apache/maven-dependency-analyzer#11).

==COMMIT_MSG==
Update maven-dependency-analyzer
==COMMIT_MSG==

Possible downsides?

  • Should be a non-breaking and backwards compatible upgrade.
  • For java 16 language support we need maven-dependency-analyzer with ASM 9 which is not yet released. But this already gives us support for java 15 language features (e.g. records, text blocks, ...)

@fawind fawind requested a review from ferozco November 10, 2020 16:14
iamdanfox
iamdanfox approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@iamdanfox iamdanfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems v uncontroversial! Could you add org.apache.maven.shared:maven-dependency-analyzer to the managed-artifacts.txt internally so we get this kind of upgrade for free next time?

@bulldozer-bot bulldozer-bot bot merged commit 0e768c4 into develop Nov 10, 2020
@bulldozer-bot bulldozer-bot bot deleted the fw/update-maven-dependency-analyzer branch November 10, 2020 16:46
@fawind
Copy link
Contributor Author

fawind commented Nov 10, 2020

Seems v uncontroversial! Could you add org.apache.maven.shared:maven-dependency-analyzer to the managed-artifacts.txt internally so we get this kind of upgrade for free next time?

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdanfox iamdanfox iamdanfox approved these changes

@ferozco ferozco Awaiting requested review from ferozco

Assignees
No one assigned
Labels
merge when ready no changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fawind @iamdanfox