Importing a BOM works even when it has the same components in dep mgmt #25
Conversation
…same components in dependency management.
| @@ -654,6 +654,7 @@ public static Test suite() | |||
| suite.addTestSuite( MavenITmng0249ResolveDepsFromReactorTest.class ); | |||
| suite.addTestSuite( MavenITmng0187CollectedProjectsTest.class ); | |||
| suite.addTestSuite( MavenITmng0095ReactorFailureBehaviorTest.class ); | |||
| suite.addTestSuite( MavenIT0199CyclicImportScopeTest.class ); | |||
There was a problem hiding this comment.
Was unclear what the naming scheme was here, so I just made something up.
| Verifier verifier = newVerifier(new File(testDir.getAbsolutePath(), module).getAbsolutePath()); | ||
| verifier.setAutoclean(false); | ||
| verifier.deleteDirectory("target"); | ||
| verifier.executeGoal("install"); |
There was a problem hiding this comment.
Tested iteratively using
rm -rfv repo/test
mvn clean test -f core-it-suite -Prun-its -Dmaven.repo.local=`pwd`/repo -Dtest=org.apache.maven.it.MavenIT0199CyclicImportScopeTest
core-it-suite/src/test/java/org/apache/maven/it/MavenIT0199CyclicImportScopeTest.java
Show resolved
Hide resolved
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
@jglick was there a Jira filed for this - I think this has got lost on the Apache side? //cc @aheritier |
|
Effectively it's often hard to monitor all PRs in all Maven related repo |
|
I do not recall any Apache JIRA issue. |
|
I've missed a lot of github activity in the period there were read only mirrors. Having 2 overlapping systems (github vs jira) generates a lot of email traffic, I'm not able to keep up and respond to it. |
…testing into cyclic-import-scope
|
this looks to be a good idea to have an IT to ensure this will keep working and as is being a documented |
|
@jglick the PR has been merged. Can you update your branch? Then I will merge it. Thanks |
…testing into cyclic-import-scope
|
Does not correspond to any known bug, but it seems like a potentially unusual practice deserving of test coverage.
CC @stephenc who wondered whether this actually works