[MRESOLVER-266] Simplify named lock adapter creation and align config source #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
approved these changes
Sep 16, 2022
michael-o
reviewed
Sep 24, 2022
...pl/src/main/java/org/eclipse/aether/internal/impl/synccontext/DefaultSyncContextFactory.java
Outdated
Show resolved
Hide resolved
michael-o
reviewed
Sep 24, 2022
...pl/src/main/java/org/eclipse/aether/internal/impl/synccontext/DefaultSyncContextFactory.java
Show resolved
Hide resolved
michael-o
requested changes
Sep 24, 2022
...pl/src/main/java/org/eclipse/aether/internal/impl/synccontext/DefaultSyncContextFactory.java
Show resolved
Hide resolved
michael-o
reviewed
Sep 24, 2022
...pl/src/main/java/org/eclipse/aether/internal/impl/synccontext/DefaultSyncContextFactory.java
Outdated
Show resolved
Hide resolved
michael-o
reviewed
Sep 24, 2022
...pl/src/main/java/org/eclipse/aether/internal/impl/synccontext/DefaultSyncContextFactory.java
Outdated
Show resolved
Hide resolved
michael-o
reviewed
Sep 24, 2022
...pl/src/main/java/org/eclipse/aether/internal/impl/synccontext/DefaultSyncContextFactory.java
Outdated
Show resolved
Hide resolved
…uration Simplified adapter creation and now as everything else in Resolver, session config properties are used as configuration source, not Java system properties. Important: This change also drops internal/impl things. Therefore, this is a breakage, IF someone uses internal/private/impl details from Resolver (mvnd does, but is fine, is our kiddo), and for the rest of the worlds: hands off, please. This closes apache#196
michael-o
force-pushed
the
MRESOLVER-266
branch
from
74076a5 to
510dcd3
Compare
michael-o
approved these changes
Sep 24, 2022
cstamas
added a commit
to cstamas/maven-resolver
that referenced
this pull request
Oct 27, 2022
Key changes: * It is not session to register handlers against, but RepositorySystem * DefaultRepositorySystemSession class deprecated, but will work as intended with a slight semantic change (it's handlers are executed on repo system shutdown) * introduced MutableRepositorySystemSession and used instead, session creation should be done using RepositorySystem and handle it as a resource * locking: partially undo PR apache#196, but do not use System properties but container injecter parameters instead (works with SISU only!)
cstamas
added a commit
to cstamas/maven-resolver
that referenced
this pull request
Oct 27, 2022
Key changes: * It is not session to register handlers against, but RepositorySystem * DefaultRepositorySystemSession class deprecated, but will work as intended with a slight semantic change (it's handlers are executed on repo system shutdown) * introduced MutableRepositorySystemSession and used instead, session creation should be done using RepositorySystem and handle it as a resource * locking: partially undo PR apache#196, but do not use System properties but container injecter parameters instead (works with SISU only!)
cstamas
added a commit
to cstamas/maven-resolver
that referenced
this pull request
Oct 28, 2022
Key changes: * It is not session to register handlers against, but RepositorySystem * DefaultRepositorySystemSession class deprecated, but will work as intended with a slight semantic change (it's handlers are executed on repo system shutdown) * introduced MutableRepositorySystemSession and used instead, session creation should be done using RepositorySystem and handle it as a resource * locking: partially undo PR apache#196, but do not use System properties but container injecter parameters instead (works with SISU only!)
cstamas
added a commit
to cstamas/maven-resolver
that referenced
this pull request
Oct 28, 2022
Key changes: * It is not session to register handlers against, but RepositorySystem * DefaultRepositorySystemSession class deprecated, but will work as intended with a slight semantic change (it's handlers are executed on repo system shutdown) * introduced MutableRepositorySystemSession and used instead, session creation should be done using RepositorySystem and handle it as a resource * locking: partially undo PR apache#196, but do not use System properties but container injecter parameters instead (works with SISU only!)
cstamas
added a commit
to cstamas/maven-resolver
that referenced
this pull request
Oct 28, 2022
Key changes: * It is not session to register handlers against, but RepositorySystem * DefaultRepositorySystemSession class deprecated, but will work as intended with a slight semantic change (it's handlers are executed on repo system shutdown) * introduced MutableRepositorySystemSession and used instead, session creation should be done using RepositorySystem and handle it as a resource * locking: partially undo PR apache#196, but do not use System properties but container injecter parameters instead (works with SISU only!)
cstamas
added a commit
that referenced
this pull request
Oct 28, 2022
Drops problematic onSessionClose, keeps only onSystemClose support. Issue will be adjusted accordingly. Key changes: * undone all related to onSessionClose * kept onRepositorySystemClose + shutdown * all 3 users on onSessionClose (locking + 2 "recording" features) will act on shutdown * moved out of session.data use as it is completely unreliable, now singleton components hold caches (hence the shutdown persistence) * DefaultSyncContext: fixed as explained, does not use system properties anymore, but is made pretty much same as before #196 * renamed all new components to `camelCase` ---- https://issues.apache.org/jira/browse/MRESOLVER-278
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified adapter creation and now as everything else in resolver, session
config properties are used as configuration source, not Java system
properties.
Note: This PR contains commit d76008f that
drop unused 3 classes (unused due simplification). This may be considered as a breakage,
IF someone uses internal/private/impl
details from resolver (mvnd does, but is fine, is our kiddo),
and for the rest of the worlds: fingers off please.
https://issues.apache.org/jira/browse/MRESOLVER-266
Supersede #188 (same change but PR recreated)